You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by hw...@apache.org on 2012/02/28 05:32:21 UTC
svn commit: r1294455 -
/subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh
Author: hwright
Date: Tue Feb 28 04:32:21 2012
New Revision: 1294455
URL: http://svn.apache.org/viewvc?rev=1294455&view=rev
Log:
* tools/buildbot/slaves/ubuntu-x64/svnbuild.sh:
Update configure args to reflect new java version.
Modified:
subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh
Modified: subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh
URL: http://svn.apache.org/viewvc/subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh?rev=1294455&r1=1294454&r2=1294455&view=diff
==============================================================================
--- subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh (original)
+++ subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh Tue Feb 28 04:32:21 2012
@@ -30,7 +30,7 @@ echo "========= autogen.sh"
echo "========= configure"
./configure --enable-javahl --enable-maintainer-mode \
--without-berkeley-db \
- --with-jdk=/usr/lib/jvm/java-6-openjdk/ \
+ --with-jdk=/usr/lib/jvm/java-7-openjdk-amd64/ \
--with-junit=/usr/share/java/junit.jar || exit $?
echo "========= make"
Re: svn commit: r1294455 - /subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh
Posted by Blair Zajac <bl...@orcaware.com>.
On 02/28/2012 05:46 AM, Mark Phippard wrote:
> On Tue, Feb 28, 2012 at 8:36 AM, Hyrum K Wright
> <hy...@wandisco.com> wrote:
>
>> I'm not sure I understand what you mean here. People will be using
>> Java 7 to attempt to build the JavaHL bindings, so I think it makes
>> sense to use them on our tests. In fact, this entire thing was
>> motivated by the fact that I upgraded the slave to the latest Ubuntu
>> Beta, and discovered it is now shipping Java 7 by default.
>
> I assume he was asking how do we make sure we do not add features in
> the source code that would only compile with JDK7.
Yes, that's correct. It's like moving from Python 2.X to 2.X+1, e.g.
the "with" keywords. Java 7 picked up some nice new features from
Project Coin [1]
> From what I
> recall, we specify the --source=1.5 option when compiling. So that
> should take care of it in terms of language features. I think we
> could technically still use new methods from the runtime libraries
> without being flagged with an error, but that is really unlikely in
> our codebase.
Using --source=1.5 should be sufficient.
Blair
[1] https://blogs.oracle.com/abuckley/resource/QConSF2011-JavaSE78.pdf
Re: svn commit: r1294455 - /subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh
Posted by Mark Phippard <ma...@gmail.com>.
On Tue, Feb 28, 2012 at 8:36 AM, Hyrum K Wright
<hy...@wandisco.com> wrote:
> I'm not sure I understand what you mean here. People will be using
> Java 7 to attempt to build the JavaHL bindings, so I think it makes
> sense to use them on our tests. In fact, this entire thing was
> motivated by the fact that I upgraded the slave to the latest Ubuntu
> Beta, and discovered it is now shipping Java 7 by default.
I assume he was asking how do we make sure we do not add features in
the source code that would only compile with JDK7. From what I
recall, we specify the --source=1.5 option when compiling. So that
should take care of it in terms of language features. I think we
could technically still use new methods from the runtime libraries
without being flagged with an error, but that is really unlikely in
our codebase.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
Re: svn commit: r1294455 - /subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh
Posted by Hyrum K Wright <hy...@wandisco.com>.
On Mon, Feb 27, 2012 at 11:14 PM, Blair Zajac <bl...@orcaware.com> wrote:
> On 2/27/12 8:34 PM, Blair Zajac wrote:
>>
>> On 2/27/12 8:32 PM, hwright@apache.org wrote:
>>>
>>> Author: hwright
>>> Date: Tue Feb 28 04:32:21 2012
>>> New Revision: 1294455
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1294455&view=rev
>>> Log:
>>> * tools/buildbot/slaves/ubuntu-x64/svnbuild.sh:
>>> Update configure args to reflect new java version.
>>>
>>> Modified:
>>> subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh
>>>
>>> Modified: subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh
>>> URL:
>>>
>>> http://svn.apache.org/viewvc/subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh?rev=1294455&r1=1294454&r2=1294455&view=diff
>>>
>>>
>>> ==============================================================================
>>> --- subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh
>>> (original)
>>> +++ subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh Tue Feb
>>> 28
>>> 04:32:21 2012
>>> @@ -30,7 +30,7 @@ echo "========= autogen.sh"
>>> echo "========= configure"
>>> ./configure --enable-javahl --enable-maintainer-mode \
>>> --without-berkeley-db \
>>> - --with-jdk=/usr/lib/jvm/java-6-openjdk/ \
>>> + --with-jdk=/usr/lib/jvm/java-7-openjdk-amd64/ \
>>
>>
>>
>> Don't we want to stay on JDK 6 so we don't inadvertently pick up new Java
>> 7
>> features?
I'm not sure I understand what you mean here. People will be using
Java 7 to attempt to build the JavaHL bindings, so I think it makes
sense to use them on our tests. In fact, this entire thing was
motivated by the fact that I upgraded the slave to the latest Ubuntu
Beta, and discovered it is now shipping Java 7 by default.
> I saw the build failures on the build box. Do we have other build boxes
> with JDK 6?
I don't know.
-Hyrum
--
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Re: svn commit: r1294455 - /subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh
Posted by Blair Zajac <bl...@orcaware.com>.
On 2/27/12 8:34 PM, Blair Zajac wrote:
> On 2/27/12 8:32 PM, hwright@apache.org wrote:
>> Author: hwright
>> Date: Tue Feb 28 04:32:21 2012
>> New Revision: 1294455
>>
>> URL: http://svn.apache.org/viewvc?rev=1294455&view=rev
>> Log:
>> * tools/buildbot/slaves/ubuntu-x64/svnbuild.sh:
>> Update configure args to reflect new java version.
>>
>> Modified:
>> subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh
>>
>> Modified: subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh
>> URL:
>> http://svn.apache.org/viewvc/subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh?rev=1294455&r1=1294454&r2=1294455&view=diff
>>
>> ==============================================================================
>> --- subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh (original)
>> +++ subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh Tue Feb 28
>> 04:32:21 2012
>> @@ -30,7 +30,7 @@ echo "========= autogen.sh"
>> echo "========= configure"
>> ./configure --enable-javahl --enable-maintainer-mode \
>> --without-berkeley-db \
>> - --with-jdk=/usr/lib/jvm/java-6-openjdk/ \
>> + --with-jdk=/usr/lib/jvm/java-7-openjdk-amd64/ \
>
>
> Don't we want to stay on JDK 6 so we don't inadvertently pick up new Java 7
> features?
I saw the build failures on the build box. Do we have other build boxes with JDK 6?
Blair
Re: svn commit: r1294455 - /subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh
Posted by Blair Zajac <bl...@orcaware.com>.
On 2/27/12 8:32 PM, hwright@apache.org wrote:
> Author: hwright
> Date: Tue Feb 28 04:32:21 2012
> New Revision: 1294455
>
> URL: http://svn.apache.org/viewvc?rev=1294455&view=rev
> Log:
> * tools/buildbot/slaves/ubuntu-x64/svnbuild.sh:
> Update configure args to reflect new java version.
>
> Modified:
> subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh
>
> Modified: subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh
> URL: http://svn.apache.org/viewvc/subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh?rev=1294455&r1=1294454&r2=1294455&view=diff
> ==============================================================================
> --- subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh (original)
> +++ subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh Tue Feb 28 04:32:21 2012
> @@ -30,7 +30,7 @@ echo "========= autogen.sh"
> echo "========= configure"
> ./configure --enable-javahl --enable-maintainer-mode \
> --without-berkeley-db \
> - --with-jdk=/usr/lib/jvm/java-6-openjdk/ \
> + --with-jdk=/usr/lib/jvm/java-7-openjdk-amd64/ \
Don't we want to stay on JDK 6 so we don't inadvertently pick up new Java 7
features?
Blair