You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2016/06/13 22:13:16 UTC

[GitHub] incubator-beam pull request #452: Fix PAssert with empty collections

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/452

    Fix PAssert with empty collections

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This branch attempts to fix this in a fairly canonical way, by actually inserting an empty iterable when the `PCollection` is empty and thus cannot be gathered via GBK.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam PAssert-empty

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/452.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #452
    
----
commit 089d8ae24a65da5a83012076ea50bb191c5b2740
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-06-13T21:28:57Z

    Fix PAssert with empty collections

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #452: Fix PAssert with empty collections

Posted by kennknowles <gi...@git.apache.org>.
Github user kennknowles closed the pull request at:

    https://github.com/apache/incubator-beam/pull/452


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---