You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "FluorineDog (via GitHub)" <gi...@apache.org> on 2023/03/03 08:27:29 UTC
[GitHub] [datasketches-cpp] FluorineDog opened a new issue, #349: random_utils is not thread-safe
FluorineDog opened a new issue, #349:
URL: https://github.com/apache/datasketches-cpp/issues/349
In our project, we use multiple kll_sketch in parallel. But it depends on random_bits:
https://github.com/apache/datasketches-cpp/blob/fa0dce5180f845020ec9c6e034ee134f1f91d580/common/include/common_defs.hpp#L40-L48
which is not thread-safe, making Thread Sanitizer(TSAN) complain about data race.
I make a [PR](https://github.com/apache/datasketches-cpp/pull/347) to solve this. it needs your approve to start ci. plz check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on issue #349: random_utils is not thread-safe
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin commented on issue #349:
URL: https://github.com/apache/datasketches-cpp/issues/349#issuecomment-1533727958
This was included in v4.1.0, which has now officially been released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov closed issue #349: random_utils is not thread-safe
Posted by "AlexanderSaydakov (via GitHub)" <gi...@apache.org>.
AlexanderSaydakov closed issue #349: random_utils is not thread-safe
URL: https://github.com/apache/datasketches-cpp/issues/349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov commented on issue #349: random_utils is not thread-safe
Posted by "AlexanderSaydakov (via GitHub)" <gi...@apache.org>.
AlexanderSaydakov commented on issue #349:
URL: https://github.com/apache/datasketches-cpp/issues/349#issuecomment-1466989313
should be fixed by #347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov commented on issue #349: random_utils is not thread-safe
Posted by "AlexanderSaydakov (via GitHub)" <gi...@apache.org>.
AlexanderSaydakov commented on issue #349:
URL: https://github.com/apache/datasketches-cpp/issues/349#issuecomment-1461108001
Could you answer my questions in the pull request please?
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org