You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by kinow <gi...@git.apache.org> on 2018/09/08 10:46:14 UTC
[GitHub] commons-lang pull request #356: Move combine.children to manifestEntries in ...
GitHub user kinow opened a pull request:
https://github.com/apache/commons-lang/pull/356
Move combine.children to manifestEntries in order to have right entries in MANIFEST.MF
Hi,
While working on Commons Imaging 1.0-alpha release candidate, I noticed that after copying most of the entries missing from Commons Lang's `pom.xml`, I couldn't pass the [step](https://commons.apache.org/releases/prepare.html) that asks to check for `X-Compile-Source-JDK` in `MANIFEST.MF` .
After some troubleshooting (and updating my Maven for the just-in-case), I realized that the combine.child seemed to result in `manifestEntries` child node being replaced.
But moving the `combine.child` to the `manifestEntries` made more sense, as that's the key that we want Maven to append parent+child.
Tested locally in Commons Imaging, and also in Commons Lang. After this change, I can successfully see the entries in the Lang's new MANIFEST.MF generated locally.
```
...
Bundle-Version: 3.9.0.SNAPSHOT
X-Compile-Target-JDK: 1.8
Implementation-Build: master@r6dc3a6db11d7e63c960ccc6cf48aa15d6f00e903
; 2018-09-08 10:35:11+0000
X-Compile-Source-JDK: 1.8
Created-By: Apache Maven Bundle Plugin
Build-Jdk: 1.8.0_181
...
```
Cheers
Bruno
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kinow/commons-lang fix-manifest-entries
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/356.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #356
----
commit 790655c1f82645d48a53456388304bf754d5470e
Author: Bruno P. Kinoshita <ki...@...>
Date: 2018-09-08T10:42:13Z
Move combine.children to manifestEntries in order to have right entries in MANIFEST.MF
----
---
[GitHub] commons-lang issue #356: Move combine.children to manifestEntries in order t...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/356
[](https://coveralls.io/builds/18894333)
Coverage remained the same at 95.253% when pulling **790655c1f82645d48a53456388304bf754d5470e on kinow:fix-manifest-entries** into **6dc3a6db11d7e63c960ccc6cf48aa15d6f00e903 on apache:master**.
---