You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm-dev@maven.apache.org by Trygve Laugstøl <tr...@student.matnat.uio.no> on 2005/01/11 00:30:01 UTC

Re: cvs commit: maven-scm/maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/update UpdateCommandTckTest.java

On Mon, 2005-01-10 at 17:04 +0000, evenisse@apache.org wrote:
> evenisse    2005/01/10 09:04:40
> 
>   Modified:    maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/update
>                         UpdateCommandTckTest.java
>   Log:
>   Remove assertion for addToRepository because svn add recursivly, by default, all files in an added dir.

All the providers should have the same default settings here. Svn can be
overridden with -N so it won't recurse by default. Perhaps all the
providers should be given a set of files to add explicit. This can be
handled in the manager if the user gives directories.

--
Trygve

>   
>   Revision  Changes    Path
>   1.12      +1 -5      maven-scm/maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/update/UpdateCommandTckTest.java
>   
>   Index: UpdateCommandTckTest.java
>   ===================================================================
>   RCS file: /home/cvs/maven-scm/maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/update/UpdateCommandTckTest.java,v
>   retrieving revision 1.11
>   retrieving revision 1.12
>   diff -u -r1.11 -r1.12
>   --- UpdateCommandTckTest.java	7 Jan 2005 15:43:20 -0000	1.11
>   +++ UpdateCommandTckTest.java	10 Jan 2005 17:04:39 -0000	1.12
>   @@ -84,10 +84,6 @@
>        {
>            AddScmResult result = getScmManager().add( repository, new ScmFileSet( workingDirectory, file ) );
>            assertTrue( "Check result was successful, output: " + result.getCommandOutput(), result.isSuccess() );
>   -
>   -        List addedFiles = result.getAddedFiles();
>   -
>   -        assertEquals( "Expected 1 files in the added files list " + addedFiles, 1, addedFiles.size() );
>        }
>    
>        private void commit( File workingDirectory, ScmRepository repository )
>   
>   
>