[jira] [Commented] (YARN-9140) Code cleanup in ResourcePluginManager.initialize and in TestResourcePluginManager

["Szilard Nemeth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788285#comment-16788285 ] 

Szilard Nemeth commented on YARN-9140:
--------------------------------------

Hi [~pbacsko]!

Added a new patch as the former had conflicts with trunk.

Short description added to Jira as requested.

Please check the latest patch!

Thanks!

> Code cleanup in ResourcePluginManager.initialize and in TestResourcePluginManager
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-9140
>                 URL: https://issues.apache.org/jira/browse/YARN-9140
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Trivial
>         Attachments: YARN-9140.001.patch, YARN-9140.002.patch
>
>
> Some code cleanup is needed in ResourcePluginManager#initialize: 
>  * There's a big code block that initializes resource plugins, this should be extracted to a separate method.
>  * Exception handling could be simplified.
> TestResourcePluginManager minor cleanup: 
>  * Not thrown exceptions could be deleted from method signatures
>  * verify(obj, times(1)).<method>() calls: times(1) parameter could be deleted as it is the default if verify(obj) is invoked without the times parameter.
>  * Some code exceeds the 80 character column limit.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org