You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Honghai Chen (JIRA)" <ji...@apache.org> on 2015/02/12 04:29:11 UTC

[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

    [ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317513#comment-14317513 ] 

Honghai Chen commented on KAFKA-1947:
-------------------------------------

After fix the command line, the command still not work, seemly more bugs in it.  Try below command
bin\kafka.cmd topiccmd --create --topic mvlogs --partition 1 --replication-factor 2     --zookeeper localhost
bin\kafka.cmd topiccmd --alter --topic mvlogs  --partitions 2   --replica-assignment  "2:3"   --zookeeper localhost

The log say:  
[2015-02-11 19:18:30,791] INFO zookeeper state changed (SyncConnected) (org.I0It
ec.zkclient.ZkClient)
WARNING: If partitions are increased for a topic that has a key, the partition l
ogic or ordering of the messages will be affected
[2015-02-11 19:18:31,427] INFO Add partition list for mvlogs is Map() (kafka.adm
in.AdminUtils$)
[2015-02-11 19:18:31,470] INFO Topic update {"version":1,"partitions":{"0":[3,1]}} (kafka.admin.AdminUtils$)
Adding partitions succeeded!
[2015-02-11 19:18:31,479] INFO Terminate ZkClient event thread. (org.I0Itec.zkcl
ient.ZkEventThread)


Seemly the JSON string is wrong!
Will continue check it.



> can't explicitly set replica-assignment when add partitions
> -----------------------------------------------------------
>
>                 Key: KAFKA-1947
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1947
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8.1.1
>         Environment: Windows
>            Reporter: Honghai Chen
>
> When create topic, the replicaAssignmentOpt should not appear with partitions.
> But when add partitions,  they should can appear together,  from the code below, you can see when alter topic, and has partitions in arguments, it try get "replica-assignment"
> https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l114 
> The root cause is below code:
> CommandLineUtils.checkInvalidArgs(parser, options, replicaAssignmentOpt,
>  305         allTopicLevelOpts -- Set(alterOpt, createOpt) + partitionsOpt + replicationFactorOpt)
> https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l304
> Related:  
> https://issues.apache.org/jira/browse/KAFKA-1052



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)