[buildstream] branch bschubert/misc-cleanups created (now 1098a7b)

[be...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

benschubert pushed a change to branch bschubert/misc-cleanups
in repository https://gitbox.apache.org/repos/asf/buildstream.git.


      at 1098a7b  repo/*: Make the Repo implementation have the same __init__ params as Repo

This branch includes the following new commits:

     new c7be7eb  testing: Fix type annotation error that mypy didn't catch
     new 1098a7b  repo/*: Make the Repo implementation have the same __init__ params as Repo

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[buildstream] 01/02: testing: Fix type annotation error that mypy didn't catch

[be...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

benschubert pushed a commit to branch bschubert/misc-cleanups
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit c7be7ebd5a6dcacc66700d76aa5c156ca51bc428
Author: Benjamin Schubert <co...@benschubert.me>
AuthorDate: Sun Oct 11 12:30:43 2020 +0000

    testing: Fix type annotation error that mypy didn't catch
---
 src/buildstream/testing/__init__.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/buildstream/testing/__init__.py b/src/buildstream/testing/__init__.py
index 3474ded..2128179 100644
--- a/src/buildstream/testing/__init__.py
+++ b/src/buildstream/testing/__init__.py
@@ -21,6 +21,7 @@ This package contains various utilities which make it easier to test plugins.
 
 import os
 from collections import OrderedDict
+from typing import Tuple
 from buildstream.exceptions import ErrorDomain, LoadErrorReason
 from ._yaml import generate_project, generate_element, load_yaml
 from .repo import Repo
@@ -47,7 +48,7 @@ except ImportError:
 
 
 # Of the form plugin_name -> (repo_class, plugin_package)
-ALL_REPO_KINDS = OrderedDict()  # type: OrderedDict[Repo, str]
+ALL_REPO_KINDS = OrderedDict()  # type: OrderedDict[str, Tuple[Repo, str]]
 
 
 def create_repo(kind, directory, subdir="repo"):

[buildstream] 02/02: repo/*: Make the Repo implementation have the same __init__ params as Repo

[be...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

benschubert pushed a commit to branch bschubert/misc-cleanups
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit 1098a7b16d63c1d367c1b5a3c5dcde4464c4820f
Author: Benjamin Schubert <co...@benschubert.me>
AuthorDate: Wed Jan 12 18:30:10 2022 +0000

    repo/*: Make the Repo implementation have the same __init__ params as Repo
---
 tests/testutils/repo/bzr.py | 2 +-
 tests/testutils/repo/git.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/testutils/repo/bzr.py b/tests/testutils/repo/bzr.py
index b698341..7421be8 100644
--- a/tests/testutils/repo/bzr.py
+++ b/tests/testutils/repo/bzr.py
@@ -7,7 +7,7 @@ from buildstream.testing._utils.site import BZR, BZR_ENV, HAVE_BZR
 
 
 class Bzr(Repo):
-    def __init__(self, directory, subdir):
+    def __init__(self, directory, subdir="repo"):
         if not HAVE_BZR:
             pytest.skip("bzr is not available")
         super().__init__(directory, subdir)
diff --git a/tests/testutils/repo/git.py b/tests/testutils/repo/git.py
index 1deca3f..02fe878 100644
--- a/tests/testutils/repo/git.py
+++ b/tests/testutils/repo/git.py
@@ -9,7 +9,7 @@ from buildstream.testing._utils.site import GIT, GIT_ENV, HAVE_GIT
 
 
 class Git(Repo):
-    def __init__(self, directory, subdir):
+    def __init__(self, directory, subdir="repo"):
         if not HAVE_GIT:
             pytest.skip("git is not available")