[GitHub] [beam] liferoad commented on a diff in pull request #28091: Return errors for insert_rows_json exceptions (#21080)

["liferoad (via GitHub)" <gi...@apache.org>]

liferoad commented on code in PR #28091:
URL: https://github.com/apache/beam/pull/28091#discussion_r1308057818


##########
sdks/python/apache_beam/io/gcp/bigquery_tools.py:
##########
@@ -732,12 +732,23 @@ def _insert_all_rows(
     except (ClientError, GoogleAPICallError) as e:
       # e.code contains the numeric http status code.
       service_call_metric.call(e.code)
-      # Re-reise the exception so that we re-try appropriately.
-      raise
-    except HttpError as e:
+      # Package exception up with required fields
+      # Set reason to 'invalid' to consider these execptions as RetryStrategy._NON_TRANSIENT_ERRORS

Review Comment:
   If these errors are retry-able, the new changes will not be able to insert these rows. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org