You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/11/09 08:50:29 UTC

[GitHub] [incubator-devlake] klesh commented on a diff in pull request #3677: feat: added MetricPluginBlueprintV200 interface

klesh commented on code in PR #3677:
URL: https://github.com/apache/incubator-devlake/pull/3677#discussion_r1017636472


##########
services/blueprint.go:
##########
@@ -254,7 +254,7 @@ func GeneratePlanJson(settings json.RawMessage) (json.RawMessage, errors.Error)
 	if err != nil {
 		return nil, errors.Default.Wrap(err, fmt.Sprintf("settings:%s", string(settings)))
 	}
-	var plan interface{}
+	var plan core.PipelinePlan
 	switch bpSettings.Version {
 	case "1.0.0":

Review Comment:
   `blueprint.project_name` is required in this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org