You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/09/12 07:15:52 UTC
[GitHub] [spark] panbingkun opened a new pull request, #42883: [SPARK-45127][DOCS] Exclude README.md from document build
panbingkun opened a new pull request, #42883:
URL: https://github.com/apache/spark/pull/42883
### What changes were proposed in this pull request?
The pr aims to exclude `README.md` from document build.
### Why are the changes needed?
1.Currently, our document `README.html` does not have any CSS style applied to it, as shown below:
https://spark.apache.org/docs/latest/README.html
<img width="1432" alt="image" src="https://github.com/apache/spark/assets/15246973/1dfe5f69-30d9-4ce4-8d82-1bba5e721ccd">
If we do not intend to display the above page to users, we should remove it during the document build process
2.As we saw in the project `spark-website`, it has already set the following configuration:
https://github.com/apache/spark-website/blob/642d1fb834817014e1799e73882d53650c1c1662/_config.yml#L7
<img width="720" alt="image" src="https://github.com/apache/spark/assets/15246973/421b7be5-4ece-407e-9d49-8e7487b74a47">
Let's stay consistent.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
- Manually test.
- Pass GA.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42883: [SPARK-45127][DOCS] Exclude README.md from document build
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42883:
URL: https://github.com/apache/spark/pull/42883#issuecomment-1722232170
cc @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #42883: [SPARK-45127][DOCS] Exclude README.md from document build
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #42883:
URL: https://github.com/apache/spark/pull/42883#issuecomment-1722237524
Merged to master/3.5/3.4/3.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #42883: [SPARK-45127][DOCS] Exclude README.md from document build
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #42883: [SPARK-45127][DOCS] Exclude README.md from document build
URL: https://github.com/apache/spark/pull/42883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org