You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/20 08:17:35 UTC

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6918: Override vr service offering

DaanHoogland commented on code in PR #6918:
URL: https://github.com/apache/cloudstack/pull/6918#discussion_r1053020703


##########
framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java:
##########
@@ -34,7 +34,7 @@
     public static final String CATEGORY_ALERT = "Alert";
 
     public static enum Scope {
-        Global, Zone, Cluster, StoragePool, Account, ManagementServer, ImageStore, Domain
+        Global, Zone, Cluster, StoragePool, Account, Domain, ManagementServer, ImageStore, Network

Review Comment:
   @JoaoJandre @soreana `scope`is stored in the DB as text. I don´t think it matters. I could imagine using ordinal numbers in some enums but not for this one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org