You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Tim Sell (JIRA)" <ji...@apache.org> on 2009/05/28 23:07:45 UTC
[jira] Created: (HBASE-1456) Backport thrift 0.1.0 changes to
branch.
Backport thrift 0.1.0 changes to branch.
----------------------------------------
Key: HBASE-1456
URL: https://issues.apache.org/jira/browse/HBASE-1456
Project: Hadoop HBase
Issue Type: Improvement
Components: thrift
Affects Versions: 0.19.2
Reporter: Tim Sell
Fix For: 0.19.2
Since so much in thrift has changed between the ancient version used in this branch and thrift 0.1.0, it will be useful to have a backport patch of all the changes so far.
There are some api tweaks. Like, gets returning lists, and just being empty when nothing was found instead of throwing NotFound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (HBASE-1456) Backport thrift 0.1.0 changes to
branch 0.19
Posted by stack <st...@duboce.net>.
Yeah, 0.19.x requires 1.6.
The one in trunk was freshly taken from the thrift 0.1 branch. Let me see
if differences between the revision that is in trunk and the RC1 and I'll
report back.
Good stuff Tim,
St.Ack
On Fri, May 29, 2009 at 5:35 PM, Tim Sell (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/HBASE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714639#action_12714639]
>
> Tim Sell commented on HBASE-1456:
> ---------------------------------
>
> Hmmm, jira seems to be down. So I'm resorting to email.
> I wget'd the thrift code from their site and compiled it myself. Using the
> jar that's in trunk probably makes more sense. Also I used java 1.6, I
> can't
> remember, do we require that for the 0.19 anyway?
> Naming it libthrift-0.1RC1.jar might be better then just libthrift (I don't
> think the one in trunk is RC1 though?), that's just how it came out of the
> thrift build process.
>
> ~Tim.
>
> 2009/5/29 stack (JIRA) <ji...@apache.org>
>
>
>
> > Backport thrift 0.1.0 changes to branch 0.19
> > --------------------------------------------
> >
> > Key: HBASE-1456
> > URL: https://issues.apache.org/jira/browse/HBASE-1456
> > Project: Hadoop HBase
> > Issue Type: Improvement
> > Components: thrift
> > Affects Versions: 0.19.2
> > Reporter: Tim Sell
> > Fix For: 0.19.2
> >
> > Attachments: HBASE-1456-v0.19.2.patch, libthrift.jar
> >
> >
> > Since so much in thrift has changed between the ancient version used in
> this branch and thrift 0.1.0, it will be useful to have a backport patch of
> all the changes so far.
> > There are some api tweaks. Like, gets returning lists, and just being
> empty when nothing was found instead of throwing NotFound.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (HBASE-1456) Backport thrift 0.1.0 changes to
branch 0.19
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714639#action_12714639 ]
Tim Sell commented on HBASE-1456:
---------------------------------
Hmmm, jira seems to be down. So I'm resorting to email.
I wget'd the thrift code from their site and compiled it myself. Using the
jar that's in trunk probably makes more sense. Also I used java 1.6, I can't
remember, do we require that for the 0.19 anyway?
Naming it libthrift-0.1RC1.jar might be better then just libthrift (I don't
think the one in trunk is RC1 though?), that's just how it came out of the
thrift build process.
~Tim.
2009/5/29 stack (JIRA) <ji...@apache.org>
> Backport thrift 0.1.0 changes to branch 0.19
> --------------------------------------------
>
> Key: HBASE-1456
> URL: https://issues.apache.org/jira/browse/HBASE-1456
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.19.2
> Reporter: Tim Sell
> Fix For: 0.19.2
>
> Attachments: HBASE-1456-v0.19.2.patch, libthrift.jar
>
>
> Since so much in thrift has changed between the ancient version used in this branch and thrift 0.1.0, it will be useful to have a backport patch of all the changes so far.
> There are some api tweaks. Like, gets returning lists, and just being empty when nothing was found instead of throwing NotFound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1456) Backport thrift 0.1.0 changes to
branch 0.19
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-1456.
--------------------------
Resolution: Won't Fix
Fix Version/s: 0.21.0
Overridden by thrift 0.2 revamp over in HBASE-1744
> Backport thrift 0.1.0 changes to branch 0.19
> --------------------------------------------
>
> Key: HBASE-1456
> URL: https://issues.apache.org/jira/browse/HBASE-1456
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Tim Sell
> Fix For: 0.21.0
>
> Attachments: HBASE-1456-v0.19.2.patch, libthrift.jar
>
>
> Since so much in thrift has changed between the ancient version used in this branch and thrift 0.1.0, it will be useful to have a backport patch of all the changes so far.
> There are some api tweaks. Like, gets returning lists, and just being empty when nothing was found instead of throwing NotFound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1456) Backport thrift 0.1.0 changes to
branch 0.19
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1456:
-------------------------
Affects Version/s: (was: 0.19.2)
> Backport thrift 0.1.0 changes to branch 0.19
> --------------------------------------------
>
> Key: HBASE-1456
> URL: https://issues.apache.org/jira/browse/HBASE-1456
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Tim Sell
> Fix For: 0.19.2
>
> Attachments: HBASE-1456-v0.19.2.patch, libthrift.jar
>
>
> Since so much in thrift has changed between the ancient version used in this branch and thrift 0.1.0, it will be useful to have a backport patch of all the changes so far.
> There are some api tweaks. Like, gets returning lists, and just being empty when nothing was found instead of throwing NotFound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1456) Backport thrift 0.1.0 changes to
branch 0.19
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714763#action_12714763 ]
stack commented on HBASE-1456:
------------------------------
So, I tried the patch. Before application TestThriftServer works, after it doesn't (Everything else passes). I looked at the patch. Nothing in there would seem to justify the failure type -- null pointer exception in the getting of master address in test harness.
I'd say, we just let the patch hang here and not apply it for now. Its not priority. Its a nice-to-have done up by the mighty tim sell. We can point thriftheads here if they are struggling.
> Backport thrift 0.1.0 changes to branch 0.19
> --------------------------------------------
>
> Key: HBASE-1456
> URL: https://issues.apache.org/jira/browse/HBASE-1456
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.19.2
> Reporter: Tim Sell
> Fix For: 0.19.2
>
> Attachments: HBASE-1456-v0.19.2.patch, libthrift.jar
>
>
> Since so much in thrift has changed between the ancient version used in this branch and thrift 0.1.0, it will be useful to have a backport patch of all the changes so far.
> There are some api tweaks. Like, gets returning lists, and just being empty when nothing was found instead of throwing NotFound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1456) Backport thrift 0.1.0 changes to
branch 0.19
Posted by "Andrew Lenards (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714529#action_12714529 ]
Andrew Lenards commented on HBASE-1456:
---------------------------------------
I applied the patch file on 0.19.2 and replaced libthrift-20080411p1.jar in {hbase-0.19.2}/lib with libthrift.jar
I'm now getting the following NoClassDefFoundError when attempting to start the thrift server:
$ bin/hbase thrift start
Exception in thread "main" java.lang.NoClassDefFoundError: com/facebook/thrift/protocol/TProtocolFactory
Caused by: java.lang.ClassNotFoundException: com.facebook.thrift.protocol.TProtocolFactory
at java.net.URLClassLoader$1.run(URLClassLoader.java:200)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:188)
at java.lang.ClassLoader.loadClass(ClassLoader.java:307)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
at java.lang.ClassLoader.loadClass(ClassLoader.java:252)
at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:320)
Could not find the main class: org.apache.hadoop.hbase.thrift.ThriftServer. Program will exit.
> Backport thrift 0.1.0 changes to branch 0.19
> --------------------------------------------
>
> Key: HBASE-1456
> URL: https://issues.apache.org/jira/browse/HBASE-1456
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.19.2
> Reporter: Tim Sell
> Fix For: 0.19.2
>
> Attachments: HBASE-1456-v0.19.2.patch, libthrift.jar
>
>
> Since so much in thrift has changed between the ancient version used in this branch and thrift 0.1.0, it will be useful to have a backport patch of all the changes so far.
> There are some api tweaks. Like, gets returning lists, and just being empty when nothing was found instead of throwing NotFound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1456) Backport thrift 0.1.0 changes to
branch.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Sell updated HBASE-1456:
----------------------------
Attachment: HBASE-1456-v0.19.2.patch
I made this from 0.19.2.
For some reason the changed unit test (from trunk) wont pass :( even if I comment out the body of testAll(), which tells me it's something to do HBaseClusterTestCase?
Incidentally, the TestThriftServer unit test fails on 0.19.2 without applying this patch.
attaching a libthrift.jar file next.
> Backport thrift 0.1.0 changes to branch.
> ----------------------------------------
>
> Key: HBASE-1456
> URL: https://issues.apache.org/jira/browse/HBASE-1456
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.19.2
> Reporter: Tim Sell
> Fix For: 0.19.2
>
> Attachments: HBASE-1456-v0.19.2.patch
>
>
> Since so much in thrift has changed between the ancient version used in this branch and thrift 0.1.0, it will be useful to have a backport patch of all the changes so far.
> There are some api tweaks. Like, gets returning lists, and just being empty when nothing was found instead of throwing NotFound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1456) Backport thrift 0.1.0 changes to
branch 0.19
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1456:
-------------------------
Fix Version/s: (was: 0.19.2)
> Backport thrift 0.1.0 changes to branch 0.19
> --------------------------------------------
>
> Key: HBASE-1456
> URL: https://issues.apache.org/jira/browse/HBASE-1456
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Tim Sell
> Attachments: HBASE-1456-v0.19.2.patch, libthrift.jar
>
>
> Since so much in thrift has changed between the ancient version used in this branch and thrift 0.1.0, it will be useful to have a backport patch of all the changes so far.
> There are some api tweaks. Like, gets returning lists, and just being empty when nothing was found instead of throwing NotFound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1456) Backport thrift 0.1.0 changes to
branch 0.19
Posted by "Andrew Lenards (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714597#action_12714597 ]
Andrew Lenards commented on HBASE-1456:
---------------------------------------
I had forgotten to rebuild the hbase code after replacing the old thrift jar. I did re-gen the thrift shim code, and redeploy that to my client (which was the updated DemoClient.py from this patch).
I would like to gleefully report that the thrift server start and that my client works!
My abject apologies for the rebuild oversight.
Thanks for the patch Tim - good on ya!
Andrew
> Backport thrift 0.1.0 changes to branch 0.19
> --------------------------------------------
>
> Key: HBASE-1456
> URL: https://issues.apache.org/jira/browse/HBASE-1456
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.19.2
> Reporter: Tim Sell
> Fix For: 0.19.2
>
> Attachments: HBASE-1456-v0.19.2.patch, libthrift.jar
>
>
> Since so much in thrift has changed between the ancient version used in this branch and thrift 0.1.0, it will be useful to have a backport patch of all the changes so far.
> There are some api tweaks. Like, gets returning lists, and just being empty when nothing was found instead of throwing NotFound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1456) Backport thrift 0.1.0 changes to
branch 0.19
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714549#action_12714549 ]
stack commented on HBASE-1456:
------------------------------
Andrew: Did you remove the old thrift lib? Did you build after applying Tim's patch? Did you rebuild your client?
Tim, on commit, I should name the jar libthrift-0.1RC1.jar? Is it same as the libthrift in TRUNIK?
> Backport thrift 0.1.0 changes to branch 0.19
> --------------------------------------------
>
> Key: HBASE-1456
> URL: https://issues.apache.org/jira/browse/HBASE-1456
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.19.2
> Reporter: Tim Sell
> Fix For: 0.19.2
>
> Attachments: HBASE-1456-v0.19.2.patch, libthrift.jar
>
>
> Since so much in thrift has changed between the ancient version used in this branch and thrift 0.1.0, it will be useful to have a backport patch of all the changes so far.
> There are some api tweaks. Like, gets returning lists, and just being empty when nothing was found instead of throwing NotFound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1456) Backport thrift 0.1.0 changes to
branch.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Sell updated HBASE-1456:
----------------------------
Attachment: libthrift.jar
This libthrift.jar is from 0.1.0 RC1
I built it using java 1.6 though.
> Backport thrift 0.1.0 changes to branch.
> ----------------------------------------
>
> Key: HBASE-1456
> URL: https://issues.apache.org/jira/browse/HBASE-1456
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.19.2
> Reporter: Tim Sell
> Fix For: 0.19.2
>
> Attachments: HBASE-1456-v0.19.2.patch, libthrift.jar
>
>
> Since so much in thrift has changed between the ancient version used in this branch and thrift 0.1.0, it will be useful to have a backport patch of all the changes so far.
> There are some api tweaks. Like, gets returning lists, and just being empty when nothing was found instead of throwing NotFound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1456) Backport thrift 0.1.0 changes to
branch 0.19
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Sell updated HBASE-1456:
----------------------------
Summary: Backport thrift 0.1.0 changes to branch 0.19 (was: Backport thrift 0.1.0 changes to branch.)
> Backport thrift 0.1.0 changes to branch 0.19
> --------------------------------------------
>
> Key: HBASE-1456
> URL: https://issues.apache.org/jira/browse/HBASE-1456
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.19.2
> Reporter: Tim Sell
> Fix For: 0.19.2
>
> Attachments: HBASE-1456-v0.19.2.patch, libthrift.jar
>
>
> Since so much in thrift has changed between the ancient version used in this branch and thrift 0.1.0, it will be useful to have a backport patch of all the changes so far.
> There are some api tweaks. Like, gets returning lists, and just being empty when nothing was found instead of throwing NotFound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1456) Backport thrift 0.1.0 changes to
branch 0.19
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802070#action_12802070 ]
Lars Francke commented on HBASE-1456:
-------------------------------------
What should we do with this?
I probably won't take any time to work on the old Thrift API and as there doesn't seem any special need for something I propose we close this ticket as won't fix. New API will be supported by the new thrift contrib (see HBASE-1744).
> Backport thrift 0.1.0 changes to branch 0.19
> --------------------------------------------
>
> Key: HBASE-1456
> URL: https://issues.apache.org/jira/browse/HBASE-1456
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Tim Sell
> Attachments: HBASE-1456-v0.19.2.patch, libthrift.jar
>
>
> Since so much in thrift has changed between the ancient version used in this branch and thrift 0.1.0, it will be useful to have a backport patch of all the changes so far.
> There are some api tweaks. Like, gets returning lists, and just being empty when nothing was found instead of throwing NotFound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.