You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/10/09 08:24:21 UTC
[GitHub] [incubator-kyuubi] CauchyHu opened a new pull request, #3596: [DOCS]update plan only execution mode doc
CauchyHu opened a new pull request, #3596:
URL: https://github.com/apache/incubator-kyuubi/pull/3596
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
it seems Flink engine is also supported
_Originally posted in https://github.com/apache/incubator-kyuubi/pull/3557#discussion_r984316871_
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [x] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Yikf commented on a diff in pull request #3596: [DOCS]update plan only execution mode doc
Posted by GitBox <gi...@apache.org>.
Yikf commented on code in PR #3596:
URL: https://github.com/apache/incubator-kyuubi/pull/3596#discussion_r990772074
##########
docs/client/advanced/features/plan_only.md:
##########
@@ -17,9 +17,9 @@
# Plan Only Execution Mode
-Plan only execution mode is implemented through Spark extensions, so it is only supported Spark engine so far.
+Plan only execution mode currently only supports Spark and Flink engine.
-It can print Spark's parsing, analysis or optimization phases execution planning, and supports application-level and session-level parameter settings, which are used in the following ways.
+It can print parsing, analysis or optimization phases execution planning, and supports application-level and session-level parameter settings, which are used in the following ways.
Review Comment:
Thanks @CauchyHu work on this, Have a minor comment, FYI, At the engine level, planOnly supports Spark and Flink currently. At the mode level, different engines support different modes. It would be better if it could be described more clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #3596: [DOCS]update plan only execution mode doc
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #3596:
URL: https://github.com/apache/incubator-kyuubi/pull/3596#issuecomment-1273163341
@CauchyHu do not worry, it is a flaky test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #3596: [DOCS]update plan only execution mode doc
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #3596:
URL: https://github.com/apache/incubator-kyuubi/pull/3596#issuecomment-1273164241
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] CauchyHu commented on pull request #3596: [DOCS]update plan only execution mode doc
Posted by GitBox <gi...@apache.org>.
CauchyHu commented on PR #3596:
URL: https://github.com/apache/incubator-kyuubi/pull/3596#issuecomment-1273142764
@ulysses-you There is a job in workflow that failed to run, is there something wrong with it? Can you retrigger it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #3596: [DOCS]update plan only execution mode doc
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #3596: [DOCS]update plan only execution mode doc
URL: https://github.com/apache/incubator-kyuubi/pull/3596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Yikf commented on pull request #3596: [DOCS]update plan only execution mode doc
Posted by GitBox <gi...@apache.org>.
Yikf commented on PR #3596:
URL: https://github.com/apache/incubator-kyuubi/pull/3596#issuecomment-1272514187
Thanks @CauchyHu work on this, Have a minor comment, FYI, At the engine level, planOnly supports Spark and Flink currently. At the mode level, different engines support different modes. It would be better if it could be described more clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #3596: [DOCS]update plan only execution mode doc
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #3596:
URL: https://github.com/apache/incubator-kyuubi/pull/3596#discussion_r990873782
##########
docs/client/advanced/features/plan_only.md:
##########
@@ -17,16 +17,16 @@
# Plan Only Execution Mode
-Plan only execution mode is implemented through Spark extensions, so it is only supported Spark engine so far.
+Plan only execution mode currently only supports Spark and Flink engine.
-It can print Spark's parsing, analysis or optimization phases execution planning, and supports application-level and session-level parameter settings, which are used in the following ways.
+Configure the kyuubi.operation.plan.only.mode parameter, The value can be 'parse', 'analyze', 'optimize', 'optimize_with_stats', 'physical', 'execution', or 'none', when it is 'none', indicate to the statement will be fully executed, otherwise only way without executing the query. different engines currently support different modes, the Spark engine supports all modes, and the Flink engine supports 'parse', 'physical', and 'execution', other engines do not support planOnly currently, and supports application-level and session-level parameter settings, which are used in the following ways.
Review Comment:
please revise the uppercase and lowercase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3596: [DOCS]update plan only execution mode doc
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3596:
URL: https://github.com/apache/incubator-kyuubi/pull/3596#issuecomment-1272504367
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3596?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3596](https://codecov.io/gh/apache/incubator-kyuubi/pull/3596?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (295065d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/f76834415a30eacbf2bfa702c7ae34ed6c814e7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f768344) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3596 +/- ##
============================================
- Coverage 51.76% 51.75% -0.02%
Complexity 13 13
============================================
Files 483 483
Lines 27020 27020
Branches 3776 3776
============================================
- Hits 13988 13983 -5
- Misses 11668 11671 +3
- Partials 1364 1366 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/engine/JpsApplicationOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3596/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvSnBzQXBwbGljYXRpb25PcGVyYXRpb24uc2NhbGE=) | `77.41% <0.00%> (-3.23%)` | :arrow_down: |
| [...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3596/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbWV0YWRhdGEvamRiYy9KREJDTWV0YWRhdGFTdG9yZS5zY2FsYQ==) | `89.27% <0.00%> (-0.70%)` | :arrow_down: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3596/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `91.17% <0.00%> (-0.30%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3596/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `97.26% <0.00%> (-0.08%)` | :arrow_down: |
| [...pache/kyuubi/engine/YarnApplicationOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3596/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvWWFybkFwcGxpY2F0aW9uT3BlcmF0aW9uLnNjYWxh) | `62.96% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org