You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "yermalov-here (via GitHub)" <gi...@apache.org> on 2023/09/08 14:39:21 UTC
[GitHub] [airflow] yermalov-here opened a new pull request, #34216: WIP: Use a AwsBaseWaiterTrigger-based trigger in EmrAddStepsOperator deferred mode
yermalov-here opened a new pull request, #34216:
URL: https://github.com/apache/airflow/pull/34216
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This PR creates a new trigger based on the AwsBaseWaiterTrigger to be used in the EmrAddStepsOperator in deferred mode.
related: #34177 , #34183
Open questions:
1. What would be the proper name for the trigger? Basically it waits for a list of steps to get to a terminal state.
2. Should the same new waiter be used in the EmrStepSensorTrigger? At the moment it uses a waiter that retrieves a single Step state.
3. What shall be done to the existing EmrAddStepsTrigger? Shall it be marked as deprecated?
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #34216: Use a AwsBaseWaiterTrigger-based trigger in EmrAddStepsOperator deferred mode
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #34216:
URL: https://github.com/apache/airflow/pull/34216#discussion_r1320309859
##########
airflow/providers/amazon/aws/triggers/emr.py:
##########
@@ -31,6 +32,7 @@
from airflow.providers.amazon.aws.hooks.base_aws import AwsGenericHook
+@deprecated(reason="use EmrStepsTrigger instead")
Review Comment:
I don't think we should deprecate it especially if it never work properly. Just need to fix it so you could move your implementation here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yermalov-here commented on pull request #34216: Use a AwsBaseWaiterTrigger-based trigger in EmrAddStepsOperator deferred mode
Posted by "yermalov-here (via GitHub)" <gi...@apache.org>.
yermalov-here commented on PR #34216:
URL: https://github.com/apache/airflow/pull/34216#issuecomment-1712422397
Replaced the implementation of the EmrAddStepsOperator
Added tests for the new waiter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #34216: Use a AwsBaseWaiterTrigger-based trigger in EmrAddStepsOperator deferred mode
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #34216:
URL: https://github.com/apache/airflow/pull/34216#discussion_r1320309859
##########
airflow/providers/amazon/aws/triggers/emr.py:
##########
@@ -31,6 +32,7 @@
from airflow.providers.amazon.aws.hooks.base_aws import AwsGenericHook
+@deprecated(reason="use EmrStepsTrigger instead")
Review Comment:
I don't think we should deprecate it especially if it never work properly just need to fix it so you could move your implementation here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vincbeck commented on pull request #34216: Use a AwsBaseWaiterTrigger-based trigger in EmrAddStepsOperator deferred mode
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #34216:
URL: https://github.com/apache/airflow/pull/34216#issuecomment-1712178550
@syedahsn @vandonr-amz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #34216: Use a AwsBaseWaiterTrigger-based trigger in EmrAddStepsOperator deferred mode
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #34216:
URL: https://github.com/apache/airflow/pull/34216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vincbeck commented on pull request #34216: Use a AwsBaseWaiterTrigger-based trigger in EmrAddStepsOperator deferred mode
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #34216:
URL: https://github.com/apache/airflow/pull/34216#issuecomment-1712179433
Why creating a new trigger and not modifying `EmrAddStepsTrigger`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yermalov-here commented on pull request #34216: Use a AwsBaseWaiterTrigger-based trigger in EmrAddStepsOperator deferred mode
Posted by "yermalov-here (via GitHub)" <gi...@apache.org>.
yermalov-here commented on PR #34216:
URL: https://github.com/apache/airflow/pull/34216#issuecomment-1711880039
Please note that i'd be glad to update this PR, especially based on the answers to the questions mentioned in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org