You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/03/16 07:44:19 UTC
[GitHub] [hbase] thangTang opened a new pull request #4232: HBASE-26849 Fix NPE caused by WAL Compression and Replication
thangTang opened a new pull request #4232:
URL: https://github.com/apache/hbase/pull/4232
Details in [HBASE-26849](https://issues.apache.org/jira/browse/HBASE-26849)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] sunhelly commented on a change in pull request #4232: HBASE-26849 Fix NPE caused by WAL Compression and Replication
Posted by GitBox <gi...@apache.org>.
sunhelly commented on a change in pull request #4232:
URL: https://github.com/apache/hbase/pull/4232#discussion_r827780740
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
##########
@@ -249,7 +249,7 @@ private boolean checkAllBytesParsed() throws IOException {
+ ", which is too far away from reported file length " + stat.getLen()
+ ". Restarting WAL reading (see HBASE-15983 for details). " + getCurrentPathStat());
setPosition(0);
- resetReader();
+ openReader(currentPath, true);
Review comment:
How about add a resetCompressionContext() method in the implementation of Reader.reset()? That means when the reader is reset, the compressionContext needs also be reset.
And then the resetReader() can be kept everywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4232: HBASE-26849 Fix NPE caused by WAL Compression and Replication
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #4232:
URL: https://github.com/apache/hbase/pull/4232#issuecomment-1068834962
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 0m 0s | Docker command '/usr/bin/docker' is too old (1.41 < API v 1.27.0). |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4232/1/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] thangTang commented on a change in pull request #4232: HBASE-26849 Fix NPE caused by WAL Compression and Replication
Posted by GitBox <gi...@apache.org>.
thangTang commented on a change in pull request #4232:
URL: https://github.com/apache/hbase/pull/4232#discussion_r827813705
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
##########
@@ -249,7 +249,7 @@ private boolean checkAllBytesParsed() throws IOException {
+ ", which is too far away from reported file length " + stat.getLen()
+ ". Restarting WAL reading (see HBASE-15983 for details). " + getCurrentPathStat());
setPosition(0);
- resetReader();
+ openReader(currentPath, true);
Review comment:
Sure. Will wait for some other comments and repush.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] thangTang commented on a change in pull request #4232: HBASE-26849 Fix NPE caused by WAL Compression and Replication
Posted by GitBox <gi...@apache.org>.
thangTang commented on a change in pull request #4232:
URL: https://github.com/apache/hbase/pull/4232#discussion_r828800413
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
##########
@@ -249,7 +249,7 @@ private boolean checkAllBytesParsed() throws IOException {
+ ", which is too far away from reported file length " + stat.getLen()
+ ". Restarting WAL reading (see HBASE-15983 for details). " + getCurrentPathStat());
setPosition(0);
- resetReader();
+ openReader(currentPath, true);
Review comment:
@sunhelly Pls see [WALEntryStream#resetReader](https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java#L391)
There will call _seek_ method, which means the resetReader also might reposition the cursor somewhere, so i think we cannot just clear the compressionContext.
As a temporary/staged fix, I think creating the reader directly is the least invasive... What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org