You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/19 12:07:43 UTC

[GitHub] [airflow] harrisjoseph opened a new pull request #8910: Accessibility - Add TaskInstance State to tiTooltip in RBAC UI

harrisjoseph opened a new pull request #8910:
URL: https://github.com/apache/airflow/pull/8910


   Currently there is no way to determine the state of a TaskInstance in the graph view or tree view, for people with Colour blindness
   
   An estimated 4.5% of people experience some form of colour vision deficiency
   
   I haven't seen any testing around task-instance.js, but will gladly write a test, or update any existing test
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Target Github ISSUE in description if exists
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #8910: Accessibility - Add TaskInstance State to tiTooltip in RBAC UI

Posted by GitBox <gi...@apache.org>.

ashb commented on pull request #8910:
URL: https://github.com/apache/airflow/pull/8910#issuecomment-631996140


   Thanks @harrisjoseph (:gb: :pencil2:  FTW.)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8910: Accessibility - Add TaskInstance State to tiTooltip in RBAC UI

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #8910:
URL: https://github.com/apache/airflow/pull/8910#issuecomment-631995867


   Awesome work, congrats on your first merged pull request!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] harrisjoseph commented on pull request #8910: Accessibility - Add TaskInstance State to tiTooltip in RBAC UI

Posted by GitBox <gi...@apache.org>.

harrisjoseph commented on pull request #8910:
URL: https://github.com/apache/airflow/pull/8910#issuecomment-632003904


   Thank you. It's an honour and a privilege. 🙇 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] harrisjoseph commented on pull request #8910: Accessibility - Add TaskInstance State to tiTooltip in RBAC UI

Posted by GitBox <gi...@apache.org>.

harrisjoseph commented on pull request #8910:
URL: https://github.com/apache/airflow/pull/8910#issuecomment-631441645


   Screenshots of the updated tooltip for reference:
   ![Screenshot 2020-05-20 at 13 25 25](https://user-images.githubusercontent.com/17148324/82445846-6e579d00-9a9d-11ea-8c88-2fe8806df54e.png)
   ![Screenshot 2020-05-20 at 13 25 34](https://user-images.githubusercontent.com/17148324/82445848-6ef03380-9a9d-11ea-9f38-e790d31ae379.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8910: Accessibility - Add TaskInstance State to tiTooltip in RBAC UI

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #8910:
URL: https://github.com/apache/airflow/pull/8910#issuecomment-630775858

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb merged pull request #8910: Accessibility - Add TaskInstance State to tiTooltip in RBAC UI

Posted by GitBox <gi...@apache.org>.

ashb merged pull request #8910:
URL: https://github.com/apache/airflow/pull/8910


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org