You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/04/15 21:56:39 UTC
[kudu-CR](branch-1.12.x) Revert "[common] update on HostPortFromPB()/HostPortToPB()"
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15740
Change subject: Revert "[common] update on HostPortFromPB()/HostPortToPB()"
......................................................................
Revert "[common] update on HostPortFromPB()/HostPortToPB()"
This reverts commit abd31bd4b13e95bea7a84108dbe5a20b837a89bc.
Change-Id: I1b2615a3dd5c3f3d2f639ce8a46d05c3845b95c4
---
M src/kudu/client/client.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/tablet_copy_client_session-itest.cc
M src/kudu/integration-tests/tombstoned_voting-stress-test.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/auto_rebalancer.cc
M src/kudu/master/master.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/server/server_base.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_replica_util.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
24 files changed, 94 insertions(+), 53 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/15740/1
--
To view, visit http://gerrit.cloudera.org:8080/15740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b2615a3dd5c3f3d2f639ce8a46d05c3845b95c4
Gerrit-Change-Number: 15740
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR](branch-1.12.x) Revert "[common] update on HostPortFromPB()/HostPortToPB()"
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15740 )
Change subject: Revert "[common] update on HostPortFromPB()/HostPortToPB()"
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b2615a3dd5c3f3d2f639ce8a46d05c3845b95c4
Gerrit-Change-Number: 15740
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Apr 2020 22:12:20 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) Revert "[common] update on HostPortFromPB()/HostPortToPB()"
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15740 )
Change subject: Revert "[common] update on HostPortFromPB()/HostPortToPB()"
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b2615a3dd5c3f3d2f639ce8a46d05c3845b95c4
Gerrit-Change-Number: 15740
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Apr 2020 22:53:58 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) Revert "[common] update on HostPortFromPB()/HostPortToPB()"
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15740 )
Change subject: Revert "[common] update on HostPortFromPB()/HostPortToPB()"
......................................................................
Revert "[common] update on HostPortFromPB()/HostPortToPB()"
This reverts commit abd31bd4b13e95bea7a84108dbe5a20b837a89bc.
Change-Id: I1b2615a3dd5c3f3d2f639ce8a46d05c3845b95c4
Reviewed-on: http://gerrit.cloudera.org:8080/15740
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/client/client.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/tablet_copy_client_session-itest.cc
M src/kudu/integration-tests/tombstoned_voting-stress-test.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/auto_rebalancer.cc
M src/kudu/master/master.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/server/server_base.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_replica_util.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
24 files changed, 94 insertions(+), 53 deletions(-)
Approvals:
Hao Hao: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b2615a3dd5c3f3d2f639ce8a46d05c3845b95c4
Gerrit-Change-Number: 15740
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)