You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/05 20:58:59 UTC

[GitHub] [incubator-superset] bkyryliuk edited a comment on pull request #10605: feat: refractored SQL-based alerting framework

bkyryliuk edited a comment on pull request #10605:
URL: https://github.com/apache/incubator-superset/pull/10605#issuecomment-703885068


   > @bkyryliuk the observer/validator pattern is really confusing, I heard there's been discussions on reverting this. Personally I feel like we should 100% revert this. What's the plan!?
   
   @mistercrunch  we have synced with @willbarrett on this topic. I will merge the observer & validator back into alert object within next 2 weeks. Will keep Observation object to support validation across multiple observations.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org