You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Bernd Mau (JIRA)" <ji...@codehaus.org> on 2005/10/21 09:52:11 UTC
[jira] Created: (MNG-1263) Multiproject Release: No check in
Multiproject Release: No check in
---------------------------------
Key: MNG-1263
URL: http://jira.codehaus.org/browse/MNG-1263
Project: Maven 2
Type: Bug
Components: maven-release-plugin
Versions: 2.0
Environment: Windows XP, Eclipse Workspace
Reporter: Bernd Mau
Priority: Critical
I tried to release a multiproject with 5 modules (on a Branch). Well,
the POMs of all modules are changed and there are some dependencies
which have been updated correctly. But only the master has been checked
in correctly.
I'm changed the recommended layout, to fit in an eclipse workspace. I
have one master at the same level as the other modules.
The module section of the master pom.xml:
<modules>
<module>../hhla.library.pom</module>
<module>../hhla.library.site</module>
<module>../hhla.lang</module>
<module>../hhla.common.log4jx</module>
</modules>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MRELEASE-6) Multiproject Release: No check in
Posted by "Kenney Westerhof (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-6?page=comments#action_57634 ]
Kenney Westerhof commented on MRELEASE-6:
-----------------------------------------
One more thing: only <type>pom</type> projects can have modules.
So I don't see any reason not to add a root pom that specifies your four modules. That way
you can have a normal tree with the modules as direct children (in the sub-directory-sense)
as was intended:
master/
/hhla....
/hhla...
Since the master would have packaging pom, it won't get included in eclipse, since it does not
produce any artifacts. I do this all the time and have absolutely no problems with it.
> Multiproject Release: No check in
> ---------------------------------
>
> Key: MRELEASE-6
> URL: http://jira.codehaus.org/browse/MRELEASE-6
> Project: Maven 2.x Release Plugin
> Type: Bug
> Environment: Windows XP, Eclipse Workspace
> Reporter: Bernd Mau
> Priority: Critical
>
>
> I tried to release a multiproject with 5 modules (on a Branch). Well,
> the POMs of all modules are changed and there are some dependencies
> which have been updated correctly. But only the master has been checked
> in correctly.
> I'm changed the recommended layout, to fit in an eclipse workspace. I
> have one master at the same level as the other modules.
> The module section of the master pom.xml:
> <modules>
> <module>../hhla.library.pom</module>
> <module>../hhla.library.site</module>
> <module>../hhla.lang</module>
> <module>../hhla.common.log4jx</module>
> </modules>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1263) Multiproject Release: No check in
Posted by "Christian Schulte (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1263?page=comments#action_51814 ]
Christian Schulte commented on MNG-1263:
----------------------------------------
see also CONTINUUM-462
> Multiproject Release: No check in
> ---------------------------------
>
> Key: MNG-1263
> URL: http://jira.codehaus.org/browse/MNG-1263
> Project: Maven 2
> Type: Bug
> Components: maven-release-plugin
> Versions: 2.0
> Environment: Windows XP, Eclipse Workspace
> Reporter: Bernd Mau
> Priority: Critical
>
>
> I tried to release a multiproject with 5 modules (on a Branch). Well,
> the POMs of all modules are changed and there are some dependencies
> which have been updated correctly. But only the master has been checked
> in correctly.
> I'm changed the recommended layout, to fit in an eclipse workspace. I
> have one master at the same level as the other modules.
> The module section of the master pom.xml:
> <modules>
> <module>../hhla.library.pom</module>
> <module>../hhla.library.site</module>
> <module>../hhla.lang</module>
> <module>../hhla.common.log4jx</module>
> </modules>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1263) Multiproject Release: No check in
Posted by "Christian Schulte (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1263?page=comments#action_51812 ]
Christian Schulte commented on MNG-1263:
----------------------------------------
This is not only a problem of the release plugin its also a problem with inheritance in Maven 2 in general. Its completely ignoring relative path settings during inheritance when building SCM-URLs and URLs. Looking at org.apache.maven.project.inheritance.DefaultModelInheritanceAssembler it seems the following assumptions have been made:
1. The artifactId is always the same as the directory-name holding the artifact
2. The parent "lives" always one level up in the hierarchy
So no matter what relative path settings are specified they are ignored in that class which builds various paths during inheritance. I am currently thinking about fixing this class but I would need some guidance to not break anything since I do not know what assumptions have been made further and if it is really only this class to fix.
A workaround for this problem is to not inherit things build from this class by e.g. specifying the SCM-URLs inside every pom and do not let maven build them for you during inheritance which holds true also for URLs.
Would it lead to problems if this class would support the relative paths without changing anything else ?
> Multiproject Release: No check in
> ---------------------------------
>
> Key: MNG-1263
> URL: http://jira.codehaus.org/browse/MNG-1263
> Project: Maven 2
> Type: Bug
> Components: maven-release-plugin
> Versions: 2.0
> Environment: Windows XP, Eclipse Workspace
> Reporter: Bernd Mau
> Priority: Critical
>
>
> I tried to release a multiproject with 5 modules (on a Branch). Well,
> the POMs of all modules are changed and there are some dependencies
> which have been updated correctly. But only the master has been checked
> in correctly.
> I'm changed the recommended layout, to fit in an eclipse workspace. I
> have one master at the same level as the other modules.
> The module section of the master pom.xml:
> <modules>
> <module>../hhla.library.pom</module>
> <module>../hhla.library.site</module>
> <module>../hhla.lang</module>
> <module>../hhla.common.log4jx</module>
> </modules>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MRELEASE-6) Multiproject Release: No check in
Posted by "Kenney Westerhof (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-6?page=comments#action_57633 ]
Kenney Westerhof commented on MRELEASE-6:
-----------------------------------------
1) that is best practise. But having a module directory 'a' containing a pom with artifactId 'b' should work though.
2) Correct, that is the default. When scanning for parent poms, first ../pom.xml is checked to see if it matches
the <parent> tag. If that fails, the local/remote repositories are consulted for that pom.
The problem here with the SCM module is that if your CVS/Subversion/Whatever repository layout does
not match the default parent/module inheritance model (module = artifactId subdir, parent = ..),
you have to specify the SCMUrl in every pom. Only when the default layout is used, Maven can make a
well educated guess on the SCM url.
The same goes for site urls, btw.
In theory, maven should use the <module> definitions to define SCM urls for child modules.
But it poses some problems. Say you want to release a submodule. You do the release there.
Maven will try to guess the SCM url by traversing the parent-tree until an SCM url is found
(actually it'll go all the way up to the built-in root pom..).
It first tries ../pom.xml, which does not exist. It then retrieves the pom from the repository. Since there's no
relation between the module directory name and the artifactId, it cannot see which of the <module> tags
corresponds to the project you're currently trying to release. It can only append the current artifactId
to that SCM url and hope it's correct.
I hope this clarifies a lot. There is no easy solution..
> Multiproject Release: No check in
> ---------------------------------
>
> Key: MRELEASE-6
> URL: http://jira.codehaus.org/browse/MRELEASE-6
> Project: Maven 2.x Release Plugin
> Type: Bug
> Environment: Windows XP, Eclipse Workspace
> Reporter: Bernd Mau
> Priority: Critical
>
>
> I tried to release a multiproject with 5 modules (on a Branch). Well,
> the POMs of all modules are changed and there are some dependencies
> which have been updated correctly. But only the master has been checked
> in correctly.
> I'm changed the recommended layout, to fit in an eclipse workspace. I
> have one master at the same level as the other modules.
> The module section of the master pom.xml:
> <modules>
> <module>../hhla.library.pom</module>
> <module>../hhla.library.site</module>
> <module>../hhla.lang</module>
> <module>../hhla.common.log4jx</module>
> </modules>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MRELEASE-6) Multiproject Release: No check in
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-6?page=comments#action_57636 ]
Olivier Lamy commented on MRELEASE-6:
-------------------------------------
Personnaly, I named directory (module and scm) striclty equals (;-) ).
In fact, I used something like this
- root-module/pom.xml
src/site/global documentation
- api-module/pom.xml
- ....
root-module as this to edit it with eclipse.
But it's easy to change to
./pom.xml (root)
site-module with global documentation
not a real trouble
Thanks,
Olivier
> Multiproject Release: No check in
> ---------------------------------
>
> Key: MRELEASE-6
> URL: http://jira.codehaus.org/browse/MRELEASE-6
> Project: Maven 2.x Release Plugin
> Type: Bug
> Environment: Windows XP, Eclipse Workspace
> Reporter: Bernd Mau
> Priority: Critical
>
>
> I tried to release a multiproject with 5 modules (on a Branch). Well,
> the POMs of all modules are changed and there are some dependencies
> which have been updated correctly. But only the master has been checked
> in correctly.
> I'm changed the recommended layout, to fit in an eclipse workspace. I
> have one master at the same level as the other modules.
> The module section of the master pom.xml:
> <modules>
> <module>../hhla.library.pom</module>
> <module>../hhla.library.site</module>
> <module>../hhla.lang</module>
> <module>../hhla.common.log4jx</module>
> </modules>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org