[GitHub] [incubator-superset] willbarrett commented on a change in pull request #8507: Allow customization of documentation icon and text

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #8507: Allow customization of documentation icon and text
URL: https://github.com/apache/incubator-superset/pull/8507#discussion_r342853155
 
 

 ##########
 File path: superset/templates/appbuilder/navbar_right.html
 ##########
 @@ -17,8 +17,11 @@
   under the License.
 #}
 
-{% set bug_report_url = appbuilder.app.config['BUG_REPORT_URL'] %}
-{% set documentation_url = appbuilder.app.config['DOCUMENTATION_URL'] %}
+{% set bug_report_url = appbuilder.app.config.get('BUG_REPORT_URL') %}
+{% set documentation_url = appbuilder.app.config.get('DOCUMENTATION_URL') %}
+{% set documentation_icon = appbuilder.app.config.get('DOCUMENTATION_ICON') %}
+{% set documentation_text = appbuilder.app.config.get('DOCUMENTATION_TEXT', 'Documentation') %}
 
 Review comment:
   +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org