You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2013/03/06 20:34:13 UTC

[jira] [Commented] (OOZIE-1204) Illustrate correct use of parameters inside SLA tags

    [ https://issues.apache.org/jira/browse/OOZIE-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595017#comment-13595017 ] 

Hadoop QA commented on OOZIE-1204:
----------------------------------

Testing JIRA OOZIE-1204

Cleaning local svn workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1035
.    Tests failed: 1
.    Tests errors: 0

.    The patch failed the following testcases:

.      testEvictionOnTimeToIdle(org.apache.oozie.service.TestPartitionDependencyManagerEhcache)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/366/
                
> Illustrate correct use of parameters inside SLA tags
> ----------------------------------------------------
>
>                 Key: OOZIE-1204
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1204
>             Project: Oozie
>          Issue Type: Improvement
>    Affects Versions: trunk
>            Reporter: Mona Chitnis
>            Assignee: jun aoki
>             Fix For: trunk
>
>         Attachments: OOZIE-1204.patch
>
>
> Can not pass parameter for SLA e.g. through bundle to coordinator
> when passed Property SLA_OFFSET from bundle to cordinator from SLA, running
> the oozie bundle doe not kicks off the coordinator. validation on bundle.xml,
> coordinator.xml passed.
> {code}
> bundle/job.properties
> ..
> MY_SLA_VALUE=10
> ..
>  ------------------- Bundle.xml -----------------     
>     <coordinator>
>    ...
> <property><name>SLA_OFFSET</name><value>${MY_SLA_VALUE}</value></property>
>        </configuration>
>     </coordinator>
> -------------------------- coordinator.xml --------------
>  <sla:info>
>       <sla:app-name>${FEED_NAME}_daily</sla:app-name>
>       <sla:nominal-time>${coord:nominalTime()}</sla:nominal-time>
>       <sla:should-start>${5 * MINUTES}</sla:should-start>
>       <sla:should-end>${ ${SLA_OFFSET} * MINUTES}</sla:should-end>
>       <sla:notification-msg>Notifying User for ${coord:nominalTime()} nominal
> time</sla:notification-msg>
> ----Log -----
>  <sla:info>
>       <sla:app-name>${FEED_NAME}_daily</sla:app-name>
>       <sla:nominal-time>${coord:nominalTime()}</sla:nominal-time>
>       <sla:should-start>${5 * MINUTES}</sla:should-start>
>       <sla:should-end>${${SLA_OFFSET} * MINUTES }</sla:should-end>
>       <sla:notification-msg>Notifying User for ${coord:nominalTime()} nominal
> time</sla:notification-msg>
>     </sla:info>
>   </action>
> </coordinator-app>
> 2013-01-31 19:52:49,923  WARN CoordSubmitXCommand:542 - USER[-] GROUP[-]
> TOKEN[-] APP[-] JOB[123-oozie-wrkf-B] ACTION[-] ERROR:
> org.apache.oozie.command.CommandException: E1004: Expression language
> evaluation error [Validation ERROR :Encountered "{", expected one of ["}", ".",
> ">", "gt", "<", "lt", "==", "eq", "<=", "le", ">=", "ge", "!=", "ne", "[", 
> "+", "-", "*", "/", "div", "%", "mod", "and", "&&", "or", "||", ":", "(",
> "?"]], javax.servlet.jsp.el.ELException: Encountered "{", expected one of ["}",
> ".", ">", "gt", "<", "lt", "==", "eq", "<=", "le", ">=", "ge", "!=", "n
> e", "[", "+", "-", "*", "/", "div", "%", "mod", "and", "&&", "or", "||", ":",
> "(", "?"]
>         at
> org.apache.oozie.command.coord.CoordSubmitXCommand.resolveSLA(CoordSubmitXCommand.java:690)
>         at
> org.apache.oozie.command.coord.CoordSubmitXCommand.resolveInitial(CoordSubmitXCommand.java:666)
>         at
> org.apache.oozie.command.coord.CoordSubmitXCommand.basicResolveAndIncludeDS(CoordSubmitXCommand.java:484)
>         at
> org.apache.oozie.command.coord.CoordSubmitXCommand.submit(CoordSubmitXCommand.java:222)
>         at
> org.apache.oozie.command.SubmitTransitionXCommand.execute(SubmitTransitionXCommand.java:81)
> {code}
> Looks like the SLA's EL Evaluator cannot evaluate the parametrized value. This needs to be fixed

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira