[GitHub] [seatunnel] Hisoka-X commented on a diff in pull request #5485: [Feature][Catalog] Add InMemoryCatalog for test and add new getCatalogTableFromConfig method

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on code in PR #5485:
URL: https://github.com/apache/seatunnel/pull/5485#discussion_r1325748636


##########
seatunnel-api/src/test/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtilTest.java:
##########
@@ -37,17 +36,13 @@
 import java.net.URISyntaxException;
 import java.net.URL;
 import java.nio.file.Paths;
+import java.util.List;
 
 public class CatalogTableUtilTest {
     @Test
     public void testSimpleSchemaParse() throws FileNotFoundException, URISyntaxException {
         String path = getTestConfigFile("/conf/simple.schema.conf");
-        Config config =

Review Comment:
   ditto



##########
seatunnel-api/src/test/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtilTest.java:
##########
@@ -61,12 +56,7 @@ public void testSimpleSchemaParse() throws FileNotFoundException, URISyntaxExcep
     @Test
     public void testComplexSchemaParse() throws FileNotFoundException, URISyntaxException {
         String path = getTestConfigFile("/conf/complex.schema.conf");
-        Config config =

Review Comment:
   ditto



##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/CatalogOptions.java:
##########
@@ -56,11 +54,4 @@ public interface CatalogOptions {
                     .withDescription(
                             "The table names RegEx of the database to capture."
                                     + "The table name needs to include the database name, for example: database_.*\\.table_.*");
-
-    OptionRule.Builder BASE_RULE =

Review Comment:
   I also removed some useless code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org