You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by omefire <gi...@git.apache.org> on 2016/04/21 23:18:46 UTC
[GitHub] cordova-medic pull request: CB-11135 iOS Contacts Perms: Handle ca...
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-medic/pull/96
CB-11135 iOS Contacts Perms: Handle case where 'cordova-cli' install …
…not global
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-medic CB-11135
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-medic/pull/96.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #96
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-11135 iOS Contacts Perms: Handle ca...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-11135 iOS Contacts Perms: Handle ca...
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-medic/pull/96#issuecomment-213161118
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-11135 iOS Contacts Perms: Handle ca...
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/96#discussion_r60665244
--- Diff: lib/util.js ---
@@ -93,9 +104,9 @@ module.exports = (function() {
medicLog("Failed to find simulator we deployed to");
return;
}
-
+ console.log("findSimResult: " + JSON.stringify(findSimResult));
--- End diff --
We should probably remove these.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-11135 iOS Contacts Perms: Handle ca...
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/96#discussion_r60665206
--- Diff: lib/util.js ---
@@ -81,8 +92,8 @@ module.exports = (function() {
return numDevices;
}
- function getSimId() {
- var findSimCommand = "cordova run --list --emulator | grep ^iPhone | tail -n1";
+ function getSimId(localCLI) {
--- End diff --
Can't we get the localCLI here by just calling getlocalCLI() instead of having to pass it to updatepermissions and then to getSimId?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-11135 iOS Contacts Perms: Handle ca...
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/96#discussion_r60666920
--- Diff: lib/util.js ---
@@ -81,8 +92,8 @@ module.exports = (function() {
return numDevices;
}
- function getSimId() {
- var findSimCommand = "cordova run --list --emulator | grep ^iPhone | tail -n1";
+ function getSimId(localCLI) {
--- End diff --
sure, we could do that too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org