You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/02/22 07:00:43 UTC
[GitHub] [incubator-eventmesh] lrhkobe opened a new issue #780: [Enhancement] EventListener defines in the level of Consumer may be more proper instead of the level of topic
lrhkobe opened a new issue #780:
URL: https://github.com/apache/incubator-eventmesh/issues/780
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
The eventListner in `Consumer.java` may be more proper if defined in the level of Consumer,instead of the level of Topic. Because the logic of eventListener is same for each topic in EventMesh.
```
void subscribe(String topic, final EventListener listener);
```
### Describe the solution you'd like
- modify method `subscribe` in `Consumer.java`, delete the binding between topic and eventListener
```
//void subscribe(String topic, final EventListener listener) throws Exception;
void subscribe(String topic) throws Exception;
```
- add method `registerEventListener` in `Consumer.java` , regist eventListener and store it in the level of Consumer
```
void registerEventListener(EventListener listener);
```
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #780: [Enhancement] EventListener defines in the level of Consumer may be more proper instead of the level of topic
Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #780:
URL: https://github.com/apache/incubator-eventmesh/issues/780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org