You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@newton.ch.collab.net> on 2002/11/07 20:12:49 UTC
Re: crash in rev 3683
Philip Martin <ph...@codematters.co.uk> writes:
> > I just compiled the newest revision of Subversion and tried
> > to run some tests with my client. But this time it crashed.
> > in the file libsvn_wc\status.c the function
> > svn_error_t *
> > svn_wc_status( ...)
>
> Oops, my fault. This ought to fix it
Thanks, Philip.
What is a command that causes this bug to happen? (Just trying to
determine how serious it is for most users, since I'm making 0.15
right now. If it's not going to strike very often, then it can wait
till the next interim release.)
-K
> Index: ../svn/subversion/libsvn_wc/status.c
> ===================================================================
> --- ../svn/subversion/libsvn_wc/status.c (revision 3683)
> +++ ../svn/subversion/libsvn_wc/status.c (working copy)
> @@ -462,6 +462,8 @@
> SVN_ERR (svn_wc_entry (&parent_entry, parent_path, parent_access,
> FALSE, pool));
> }
> + else
> + parent_entry = NULL;
> }
>
> SVN_ERR (assemble_status (&s, path, adm_access, entry, parent_entry,
>
>
> --
> Philip Martin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: crash in rev 3683
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Philip Martin <ph...@codematters.co.uk> writes:
> It's pretty serious, I made it crash by running 'svn st -u' on a
> working copy updated to revision 0. I think it's the new files in a
> new directory that cause it.
Crap :-).
Okay. Can you commit and I'll reroll?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: crash in rev 3683
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Philip Martin <ph...@codematters.co.uk> writes:
> I'm looking at a regression test, but I'll leave it until post 0.15.
No need, I got one into 0.15 :-).
-K, feeling smug, then remembering how many regression tests he
*hasn't* written, then not feeling so smug anymore.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: crash in rev 3683
Posted by Stefan Küng <st...@catv.rol.ch>.
> Just went to read your README.txt ... note that Subversion is first-letter
> cap. Your document has "SubVersion" all over the place :-(
>
> /me goes back to reading...
ok, then /me goes back to do a find and replace and then commit :)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: crash in rev 3683
Posted by Greg Stein <gs...@lyra.org>.
On Thu, Nov 07, 2002 at 10:50:32PM +0100, Stefan Küng wrote:
> > Well, to be fair he identified the fix, which is even better! It's a
> > fairly obvious bug, it's just that we only call svn_wc_status from the
> > status_editor, and it appears the regression test suite never sees
> > repository added items in a working copy root. I think Stefan may be
> > using his own client?
>
> Yes. I'm working on TortoiseSVN (www.tortoisesvn.org). It's not
> yet finished, some commands are still not implemented but the main
> part is already working.
Just went to read your README.txt ... note that Subversion is first-letter
cap. Your document has "SubVersion" all over the place :-(
/me goes back to reading...
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: crash in rev 3683
Posted by Stefan Küng <st...@catv.rol.ch>.
> Well, to be fair he identified the fix, which is even better! It's a
> fairly obvious bug, it's just that we only call svn_wc_status from the
> status_editor, and it appears the regression test suite never sees
> repository added items in a working copy root. I think Stefan may be
> using his own client?
Yes. I'm working on TortoiseSVN (www.tortoisesvn.org). It's not
yet finished, some commands are still not implemented but the main
part is already working.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: crash in rev 3683
Posted by Philip Martin <ph...@codematters.co.uk>.
Karl Fogel <kf...@newton.ch.collab.net> writes:
> Just a general note: the best thing is just to give an exact
> transcript, including the literal command you ran. That way we know
> whether you ran 'svn status -v', or just 'svn status', or if perhaps
> you were using some other client that binds to the svn libraries, or
> whatever... The more concrete the information, the better.
Well, to be fair he identified the fix, which is even better! It's a
fairly obvious bug, it's just that we only call svn_wc_status from the
status_editor, and it appears the regression test suite never sees
repository added items in a working copy root. I think Stefan may be
using his own client?
I'm looking at a regression test, but I'll leave it until post 0.15.
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: crash in rev 3683
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Stefan Küng <st...@catv.rol.ch> writes:
> > > What is a command that causes this bug to happen? (Just trying to
> > > determine how serious it is for most users, since I'm making 0.15
> > > right now. If it's not going to strike very often, then it can wait
> > > till the next interim release.)
>
> It crashes in my client when I try to get a status for a svn root directory
> with the function svn_wc_status(..)
Thanks!
Just a general note: the best thing is just to give an exact
transcript, including the literal command you ran. That way we know
whether you ran 'svn status -v', or just 'svn status', or if perhaps
you were using some other client that binds to the svn libraries, or
whatever... The more concrete the information, the better.
Anyway, looks like Philip is on top of this one, so no need to go back
and get the transcript, I think.
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: crash in rev 3683
Posted by Stefan Küng <st...@catv.rol.ch>.
>
> > What is a command that causes this bug to happen? (Just trying to
> > determine how serious it is for most users, since I'm making 0.15
> > right now. If it's not going to strike very often, then it can wait
> > till the next interim release.)
It crashes in my client when I try to get a status for a svn root directory
with the function svn_wc_status(..)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: crash in rev 3683
Posted by Philip Martin <ph...@codematters.co.uk>.
Karl Fogel <kf...@newton.ch.collab.net> writes:
> Philip Martin <ph...@codematters.co.uk> writes:
> > > I just compiled the newest revision of Subversion and tried
> > > to run some tests with my client. But this time it crashed.
> > > in the file libsvn_wc\status.c the function
> > > svn_error_t *
> > > svn_wc_status( ...)
> >
> > Oops, my fault. This ought to fix it
>
> Thanks, Philip.
>
> What is a command that causes this bug to happen? (Just trying to
> determine how serious it is for most users, since I'm making 0.15
> right now. If it's not going to strike very often, then it can wait
> till the next interim release.)
It's pretty serious, I made it crash by running 'svn st -u' on a
working copy updated to revision 0. I think it's the new files in a
new directory that cause it.
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org