You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "inponomarev (via GitHub)" <gi...@apache.org> on 2026/01/27 16:49:51 UTC
[PR] TEXT-239: TextStringBuilder.append(char[], int, int) uses wrong variable in exception message [commons-text]
inponomarev opened a new pull request, #735:
URL: https://github.com/apache/commons-text/pull/735
This PR fixes [TEXT-239](https://issues.apache.org/jira/browse/TEXT-239) by correcting the exception message in
`TextStringBuilder.append(char[], int, int)` when startIndex is invalid.
A regression test is included to verify both invalid length and invalid startIndex cases report the correct variable.
⚠️ The same issue exists in deprecated `StrBuilder` implementations (`commons-text` / `commons-lang`). This PR intentionally limits the change to `TextStringBuilder`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEXT-239: TextStringBuilder.append(char[], int, int) uses wrong variable in exception message [commons-text]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #735:
URL: https://github.com/apache/commons-text/pull/735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEXT-239: TextStringBuilder.append(char[], int, int) uses wrong variable in exception message [commons-text]
Posted by "inponomarev (via GitHub)" <gi...@apache.org>.
inponomarev commented on PR #735:
URL: https://github.com/apache/commons-text/pull/735#issuecomment-3808735410
Hi @garydgregory , thank you for reviewing this.
I added the fix+regression test for the deprecated `StrBuilder`, rebased my branch and made sure Checkstyle is happy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org