You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2015/03/10 03:52:20 UTC

[GitHub] tajo pull request: TAJO-1380: Update JDBC documentation for new JD...

GitHub user dongjoon-hyun opened a pull request:

    https://github.com/apache/tajo/pull/405

    TAJO-1380: Update JDBC documentation for new JDBC driver

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/tajo TAJO-1380

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/405.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #405
    
----
commit 4aef17f893207eb32adda2178829846847d2a4f6
Author: Dongjoon Hyun <do...@apache.org>
Date:   2015-03-10T02:47:39Z

    TAJO-1380: Update JDBC documentation for new JDBC driver

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1380: Update JDBC documentation for new JD...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/405#issuecomment-78177487
  
    Thank you :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1380: Update JDBC documentation for new JD...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/405#issuecomment-78129234
  
    Thank you for your work. The patch looks good to me. I leaved one trivial comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1380: Update JDBC documentation for new JD...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the pull request:

    https://github.com/apache/tajo/pull/405#issuecomment-78157886
  
    Thank you for your feedback. No problem. Do you mean the following links? Which one do you prefer?
    
    1. http://apache.org/dyn/closer.cgi/tajo/tajo-0.10.0/tajo-jdbc-0.10.0.jar
    
    2. http://www.us.apache.org/dist/tajo/tajo-0.10.0/tajo-jdbc-0.10.0.jar
    
    By the way, those have a version number in the link, so we should update carefully. 
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1380: Update JDBC documentation for new JD...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/405


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1380: Update JDBC documentation for new JD...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/405#issuecomment-78173350
  
    I just meant the title name. The link 'http://tajo.apache.org/downloads.html' would be best because this page can track the number of downloads for each release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1380: Update JDBC documentation for new JD...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the pull request:

    https://github.com/apache/tajo/pull/405#issuecomment-78174568
  
    Oh, I see. You mean literally 'Direct Download' instead of 'From Tajo Homepage'.
    Okay, I will change soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1380: Update JDBC documentation for new JD...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the pull request:

    https://github.com/apache/tajo/pull/405#issuecomment-78404305
  
    Oh, I updated my pull request here (GitHub) and forgot to upload in Jira issue. I will update the attachement file in Jira issue soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1380: Update JDBC documentation for new JD...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/405#discussion_r26156815
  
    --- Diff: tajo-docs/src/main/sphinx/jdbc_driver.rst ---
    @@ -9,11 +9,15 @@ In this section, we explain how to get JDBC driver and an example code.
     How to get JDBC driver
     =======================
     
    +From Tajo Homepage
    --- End diff --
    
    I have one trivial suggestion. How about 'Direct Download'? In my view, It would be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---