[GitHub] john-bodley opened a new pull request #4827: [config] Updating configuration logic

[GitBox <gi...@apache.org>]

john-bodley opened a new pull request #4827: [config] Updating configuration logic
URL: https://github.com/apache/incubator-superset/pull/4827
 
 
   This PR standardizes the configuration logic following the [suggestions](http://flask.pocoo.org/docs/0.12/config/#configuring-from-files) defined in the Flask documentation.
   
   Pros:
   - Uses the recommended Flask approach.
   - Reduces the number of configuration options and environment variables from three (`PYTHONPATH`, `SUPERSET_CONFIG`, `SUPERSET_CONFIG_PATH`) to one (`SUPERSET_CONFIG_FILE`). Note I renamed `SUPERSET_CONFIG_PATH` to `SUPERSET_CONFIG_FILE` as it is more intuitive that it refers to a file as opposed to either a directory or file path.
   - Raises an error for ill-defined config files. Note previously neither of the `PYTHONPATH` or `SUPERSET_CONFIG_PATH` approaches would raise an error if the config file all ill-formed which meant it wasn't apparent what state the configuration was in.
   - Reduces the code footprint.
   
   Cons:
   - Breaking change. The `PYTHONPATH` environment variable needs to be replaced with the `SUPERSET_CONFIG_FILE`.
   
   to: @fabianmenges @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services