You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by GitBox <gi...@apache.org> on 2020/08/06 06:30:06 UTC

[GitHub] [jmeter] pmouawad opened a new pull request #608: Bug 64553 When using Transaction Controller, send Bytes and Received Bytes are displayed as 0 in the influxdb(BackendListener)

pmouawad opened a new pull request #608:
URL: https://github.com/apache/jmeter/pull/608


   ## Description
   Fix bug 64553
   
   ## Motivation and Context
   
   https://bz.apache.org/bugzilla/show_bug.cgi?id=64553
   
   ## How Has This Been Tested?
   
   Check sent data to Influx
   
   
   ## Types of changes
   
   - Bug fix
   
   ## Checklist:
   
   - [X] My code follows the [code style][style-guide] of this project.
   - [ ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] pmouawad commented on pull request #608: Bug 64553 When using Transaction Controller, send Bytes and Received Bytes are displayed as 0 in the influxdb(BackendListener)

Posted by GitBox <gi...@apache.org>.
pmouawad commented on pull request #608:
URL: https://github.com/apache/jmeter/pull/608#issuecomment-681960538


   Hello @FSchumacher , @ham1 ,
   Thanks for improving the PR.
   Can it be merged now ?
   
   Regards
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] FSchumacher commented on pull request #608: Bug 64553 When using Transaction Controller, send Bytes and Received Bytes are displayed as 0 in the influxdb(BackendListener)

Posted by GitBox <gi...@apache.org>.
FSchumacher commented on pull request #608:
URL: https://github.com/apache/jmeter/pull/608#issuecomment-682145319


   > Hello @FSchumacher , @ham1 ,
   > Thanks for improving the PR.
   > Can it be merged now ?
   
   If it is still doing, what you intended, you can merge the PR.
   
   Felix
   
   > 
   > Regards
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] pmouawad commented on pull request #608: Bug 64553 When using Transaction Controller, send Bytes and Received Bytes are displayed as 0 in the influxdb(BackendListener)

Posted by GitBox <gi...@apache.org>.
pmouawad commented on pull request #608:
URL: https://github.com/apache/jmeter/pull/608#issuecomment-674523648


   Hello Graham,
   Thanks for review.
   Feel free to improve the PR as the code is in JMeter branch.
   I Will not be able to do anything on it before september at least.
   
   Regards
   
   On Saturday, August 8, 2020, Graham Russell <no...@github.com>
   wrote:
   
   > *@ham1* commented on this pull request.
   > ------------------------------
   >
   > In src/components/src/test/java/org/apache/jmeter/visualizers/backend/
   > SamplerMetricTimedModeTest.java
   > <https://github.com/apache/jmeter/pull/608#discussion_r467487552>:
   >
   > > @@ -58,7 +58,7 @@ public void checkResetOkAndAllStats() throws Exception {
   >      public void checkResetKoAndAllStats() throws Exception {
   >
   >          SamplerMetric metric = new SamplerMetric();
   > -        metric.add(createSampleResult(false));
   > +        metric.add(createSampleResult(false), false);
   >
   > Worth adding at least a test for the true case?
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/jmeter/pull/608#pullrequestreview-463817196>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAX3RKYSCP2XPD6W5QLHHMTR7WFEFANCNFSM4PWH4TIA>
   > .
   >
   
   
   -- 
   Cordialement
   Philippe M.
   Ubik-Ingenierie
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] FSchumacher commented on a change in pull request #608: Bug 64553 When using Transaction Controller, send Bytes and Received Bytes are displayed as 0 in the influxdb(BackendListener)

Posted by GitBox <gi...@apache.org>.
FSchumacher commented on a change in pull request #608:
URL: https://github.com/apache/jmeter/pull/608#discussion_r467488637



##########
File path: src/components/src/main/java/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
##########
@@ -209,14 +209,15 @@ private void addErrorMetric(String transaction, ErrorMetric err, long count) {
     private void addMetric(String transaction, int count,
                            Long sentBytes, Long receivedBytes,
                            String statut, double mean, double minTime, double maxTime,
+                           int hits,
                            Collection<Float> pcts, PercentileProvider percentileProvider) {
         if (count <= 0) {
             return;
         }
         StringBuilder tag = new StringBuilder(95);
         tag.append(TAG_APPLICATION).append(applicationName);
-        tag.append(TAG_STATUS).append(statut);
         tag.append(TAG_TRANSACTION).append(transaction);
+        tag.append(TAG_STATUS).append(statut);

Review comment:
       We could fix the typo of the parameter while we're here :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] pmouawad merged pull request #608: Bug 64553 When using Transaction Controller, send Bytes and Received Bytes are displayed as 0 in the influxdb(BackendListener)

Posted by GitBox <gi...@apache.org>.
pmouawad merged pull request #608:
URL: https://github.com/apache/jmeter/pull/608


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] ham1 commented on a change in pull request #608: Bug 64553 When using Transaction Controller, send Bytes and Received Bytes are displayed as 0 in the influxdb(BackendListener)

Posted by GitBox <gi...@apache.org>.
ham1 commented on a change in pull request #608:
URL: https://github.com/apache/jmeter/pull/608#discussion_r467487438



##########
File path: src/components/src/main/java/org/apache/jmeter/visualizers/backend/SamplerMetric.java
##########
@@ -99,8 +99,9 @@ public static void setDefaultWindowMode(WindowMode windowMode) {
     /**
      * Add a {@link SampleResult} to be used in the statistics
      * @param result {@link SampleResult} to be used
+     * @param isCumulated is the overall Sampler Metric
      */
-    public synchronized void add(SampleResult result) {
+    public synchronized void add(SampleResult result, boolean isCumulated) {

Review comment:
       Could we use two separate methods instead of a boolean flag?
   
   I think
   
   `samplerMetric.add(sampleResult, false)`
   `getSamplerMetric(CUMULATED_METRICS).add(sampleResult, true);`
   
   isn't as readable as:
   
   `samplerMetric.add(sampleResult)`
   `getSamplerMetric(CUMULATED_METRICS).addCumulative(sampleResult);`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] ham1 commented on a change in pull request #608: Bug 64553 When using Transaction Controller, send Bytes and Received Bytes are displayed as 0 in the influxdb(BackendListener)

Posted by GitBox <gi...@apache.org>.
ham1 commented on a change in pull request #608:
URL: https://github.com/apache/jmeter/pull/608#discussion_r467487552



##########
File path: src/components/src/test/java/org/apache/jmeter/visualizers/backend/SamplerMetricTimedModeTest.java
##########
@@ -58,7 +58,7 @@ public void checkResetOkAndAllStats() throws Exception {
     public void checkResetKoAndAllStats() throws Exception {
 
         SamplerMetric metric = new SamplerMetric();
-        metric.add(createSampleResult(false));
+        metric.add(createSampleResult(false), false);

Review comment:
       Worth adding at least a test for the `true` case?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org