You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "ferrirW (via GitHub)" <gi...@apache.org> on 2023/05/24 09:29:26 UTC

[GitHub] [rocketmq] ferrirW commented on a diff in pull request #6801: [ISSUE #6800] fix: wrong setter for config isEnableBatchPush

ferrirW commented on code in PR #6801:
URL: https://github.com/apache/rocketmq/pull/6801#discussion_r1203786328


##########
store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java:
##########
@@ -1129,7 +1129,7 @@ public boolean isEnableBatchPush() {
         return isEnableBatchPush;
     }
 
-    public void setEnableBatchPush(boolean enableBatchPush) {
+    public void setIsEnableBatchPush(boolean enableBatchPush) {
         isEnableBatchPush = enableBatchPush;

Review Comment:
   IMO，change the isEnableBatchPush to enableBatchPush is better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org