You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/16 14:51:31 UTC
[GitHub] twalthr commented on a change in pull request #7493: [FLINK-11036]
Fix test_streaming_classloader.sh end-to-end test
twalthr commented on a change in pull request #7493: [FLINK-11036] Fix test_streaming_classloader.sh end-to-end test
URL: https://github.com/apache/flink/pull/7493#discussion_r248308780
##########
File path: flink-end-to-end-tests/test-scripts/test_streaming_classloader.sh
##########
@@ -28,6 +28,9 @@ sed -i -e 's/classloader.resolve-order: .*//' "$FLINK_DIR/conf/flink-conf.yaml"
sed -i -e 's/classloader.parent-first-patterns: .*//' $FLINK_DIR/conf/flink-conf.yaml
echo "classloader.resolve-order: parent-first" >> "$FLINK_DIR/conf/flink-conf.yaml"
+echo "Moving fake LibPackage.jar from end-to-end tests to lib/"
+cp ${END_TO_END_DIR}/flink-parent-child-classloading-test-lib-package/target/LibPackage.jar ${FLINK_DIR}/lib/
Review comment:
Undo the move in a cleanup trap similar to `test_streaming_sql.sh`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services