[arrow-ballista] branch master updated: Support building docker images with release-lto (#464)

[ag...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

agrove pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-ballista.git


The following commit(s) were added to refs/heads/master by this push:
     new 7b403604 Support building docker images with release-lto (#464)
7b403604 is described below

commit 7b403604eef18427fa70d387e38ccf472507d3e6
Author: Andy Grove <an...@gmail.com>
AuthorDate: Fri Oct 28 06:53:52 2022 -0600

    Support building docker images with release-lto (#464)
---
 dev/build-ballista-docker.sh     | 4 +++-
 dev/build-ballista-rust.sh       | 4 +++-
 dev/docker/builder-entrypoint.sh | 2 +-
 dev/release/README.md            | 5 +----
 4 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/dev/build-ballista-docker.sh b/dev/build-ballista-docker.sh
index 14a37d78..97288431 100755
--- a/dev/build-ballista-docker.sh
+++ b/dev/build-ballista-docker.sh
@@ -19,9 +19,11 @@
 
 set -e
 
+RELEASE_FLAG=${RELEASE_FLAG:=release}
+
 docker build -t ballista-builder --build-arg EXT_UID="$(id -u)" -f dev/docker/ballista-builder.Dockerfile .
 
-docker run -v $(pwd):/home/builder/workspace ballista-builder
+docker run -v $(pwd):/home/builder/workspace --env RELEASE_FLAG=$RELEASE_FLAG ballista-builder
 
 docker-compose build
 
diff --git a/dev/build-ballista-rust.sh b/dev/build-ballista-rust.sh
index d75275fc..16e5bf8c 100755
--- a/dev/build-ballista-rust.sh
+++ b/dev/build-ballista-rust.sh
@@ -19,6 +19,8 @@
 
 set -e
 
+RELEASE_FLAG=${RELEASE_FLAG:=release}
+
 docker build -t ballista-builder --build-arg EXT_UID="$(id -u)" -f dev/docker/ballista-builder.Dockerfile .
 
-docker run -v $(pwd):/home/builder/workspace ballista-builder
+docker run -v $(pwd):/home/builder/workspace --env RELEASE_FLAG=$RELEASE_FLAG ballista-builder
diff --git a/dev/docker/builder-entrypoint.sh b/dev/docker/builder-entrypoint.sh
index 52137d59..1f0ab1fc 100755
--- a/dev/docker/builder-entrypoint.sh
+++ b/dev/docker/builder-entrypoint.sh
@@ -22,7 +22,7 @@ set -x
 
 printenv
 RELEASE_FLAG=${RELEASE_FLAG:=release}
-cargo build --features flight-sql "--$RELEASE_FLAG" "$@"
+cargo build --features flight-sql --profile $RELEASE_FLAG "$@"
 
 cd ballista/scheduler/ui
 yarn install
diff --git a/dev/release/README.md b/dev/release/README.md
index 1cabfcf7..aa3af8c0 100644
--- a/dev/release/README.md
+++ b/dev/release/README.md
@@ -296,12 +296,9 @@ We do not yet publish Docker images to the official Apache DockerHub account but
 To build Docker images:
 
 ```shell
-BALLISTA_VERSION=0.8.0 ./dev/build-ballista-docker.sh
+RELEASE_FLAG=release-lto ./dev/build-ballista-docker.sh
 ```
 
-Note that it is not currently possible to build the Docker images on Apple silicon. Tracking issue is
-[#17](https://github.com/apache/arrow-ballista/issues/17).
-
 The Docker image is tagged as `apache/arrow-ballista:0.8.0`.
 
 ### Call the vote