You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "AliKhalili (via GitHub)" <gi...@apache.org> on 2024/03/14 12:48:42 UTC
[I] [C#] Avoid logger instantiations per request [arrow]
AliKhalili opened a new issue, #40553:
URL: https://github.com/apache/arrow/issues/40553
### Describe the enhancement requested
In .NET, the method `CreateLogger<T>` yields an instance of `ILogger<T>` and consistently generates a fresh `Logger<T>` object. On the other hand, invoking `CreateLogger(typeof(T))` results in a non-generic `ILogger` instance and defers to the factory's `CreateLogger` method, usually without creating a new instance.
It would be beneficial to modify this behavior within the `FlightSqlServer` [base class](https://github.com/apache/arrow/blob/bad7b1af8c5bb44c433c78caed8700f96ef2b9f2/csharp/src/Apache.Arrow.Flight.Sql/FlightSqlServer.cs#L215) to prevent the allocation of a new logger with each request.
### Component(s)
C#
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C#] Avoid logger instantiations per request [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on issue #40553:
URL: https://github.com/apache/arrow/issues/40553#issuecomment-2002783952
Issue resolved by pull request 40554
https://github.com/apache/arrow/pull/40554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C#] Avoid logger instantiations per request [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher closed issue #40553: [C#] Avoid logger instantiations per request
URL: https://github.com/apache/arrow/issues/40553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org