You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by flimzy <gi...@git.apache.org> on 2015/08/18 18:41:05 UTC
[GitHub] couchdb-documentation pull request: A number of documentation fixe...
GitHub user flimzy opened a pull request:
https://github.com/apache/couchdb-documentation/pull/27
A number of documentation fixes
Grammar, spelling, typos, formatting, etc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/flimzy/couchdb-documentation grammar
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-documentation/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit 998942ca01a827b0f83e34ffc4f364ed100bc52a
Author: Jonathan Hall <jh...@efolder.net>
Date: 2015-08-17T22:11:53Z
Fix typos, spelling and grammatical errors.
commit 6332e1bd969da4abd4f76a004ca8f7d92d11ebc3
Author: Jonathan Hall <jh...@efolder.net>
Date: 2015-08-17T22:16:44Z
Consistent capitalization of 'JavaScript'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation pull request: A number of documentation fixe...
Posted by flimzy <gi...@git.apache.org>.
Github user flimzy commented on a diff in the pull request:
https://github.com/apache/couchdb-documentation/pull/27#discussion_r37335404
--- Diff: src/couchapp/ddocs.rst ---
@@ -93,23 +92,23 @@ Reduce and rereduce functions
:return: Reduces `values`
Reduce functions takes two required arguments of keys and values lists - the
-result of the related map function - and optional third one which indicates if
-`rereduce` mode is active or not. `Rereduce` is using for additional reduce
+result of the related map function - and an optional third value which indicates
+if `rereduce` mode is active or not. `Rereduce` is used for additional reduce
values list, so when it is ``true`` there is no information about related `keys`
(first argument is ``null``).
-Note, that if produced result by `reduce` function is longer than initial
+Note that if the result of a `reduce` function is longer than the initial
values list then a Query Server error will be raised. However, this behavior
-could be disabled by setting ``reduce_limit`` config option to ``false``:
+can be disabled by setting ``reduce_limit`` config option to ``false``:
.. code-block:: ini
[query_server_config]
reduce_limit = false
-While disabling ``reduce_limit`` might be useful for debug proposes, remember,
-that main task of reduce functions is to *reduce* mapped result, not to make it
-even bigger. Generally, your reduce function should converge rapidly to a single
+While disabling ``reduce_limit`` might be useful for debug proposes, remember
+that the main task of reduce functions is to *reduce* mapped result, not to make
+them bigger. Generally, your reduce function should converge rapidly to a single
--- End diff --
It's fixed now (to my satisfaction, anyway... feel free to disagree) :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation pull request: A number of documentation fixe...
Posted by flimzy <gi...@git.apache.org>.
Github user flimzy commented on the pull request:
https://github.com/apache/couchdb-documentation/pull/27#issuecomment-132289728
It's passing now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation pull request: A number of documentation fixe...
Posted by flimzy <gi...@git.apache.org>.
Github user flimzy commented on a diff in the pull request:
https://github.com/apache/couchdb-documentation/pull/27#discussion_r37333655
--- Diff: src/couchapp/ddocs.rst ---
@@ -93,23 +92,23 @@ Reduce and rereduce functions
:return: Reduces `values`
Reduce functions takes two required arguments of keys and values lists - the
-result of the related map function - and optional third one which indicates if
-`rereduce` mode is active or not. `Rereduce` is using for additional reduce
+result of the related map function - and an optional third value which indicates
+if `rereduce` mode is active or not. `Rereduce` is used for additional reduce
values list, so when it is ``true`` there is no information about related `keys`
(first argument is ``null``).
-Note, that if produced result by `reduce` function is longer than initial
+Note that if the result of a `reduce` function is longer than the initial
values list then a Query Server error will be raised. However, this behavior
-could be disabled by setting ``reduce_limit`` config option to ``false``:
+can be disabled by setting ``reduce_limit`` config option to ``false``:
.. code-block:: ini
[query_server_config]
reduce_limit = false
-While disabling ``reduce_limit`` might be useful for debug proposes, remember,
-that main task of reduce functions is to *reduce* mapped result, not to make it
-even bigger. Generally, your reduce function should converge rapidly to a single
+While disabling ``reduce_limit`` might be useful for debug proposes, remember
+that the main task of reduce functions is to *reduce* mapped result, not to make
+them bigger. Generally, your reduce function should converge rapidly to a single
--- End diff --
It should probably say "to reduce mapped results" (which is probably what I read), or "to reduce the mapped result", in which case the singular "it" would be correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation pull request: A number of documentation fixe...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-documentation/pull/27#issuecomment-132277763
Thanks for the fixes, but it seems build is broken by these changes. Please check travis logs for the issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation pull request: A number of documentation fixe...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-documentation/pull/27#issuecomment-133678578
Merged, thanks a lot! (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation pull request: A number of documentation fixe...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-documentation/pull/27#discussion_r37335732
--- Diff: src/couchapp/ddocs.rst ---
@@ -93,23 +92,23 @@ Reduce and rereduce functions
:return: Reduces `values`
Reduce functions takes two required arguments of keys and values lists - the
-result of the related map function - and optional third one which indicates if
-`rereduce` mode is active or not. `Rereduce` is using for additional reduce
+result of the related map function - and an optional third value which indicates
+if `rereduce` mode is active or not. `Rereduce` is used for additional reduce
values list, so when it is ``true`` there is no information about related `keys`
(first argument is ``null``).
-Note, that if produced result by `reduce` function is longer than initial
+Note that if the result of a `reduce` function is longer than the initial
values list then a Query Server error will be raised. However, this behavior
-could be disabled by setting ``reduce_limit`` config option to ``false``:
+can be disabled by setting ``reduce_limit`` config option to ``false``:
.. code-block:: ini
[query_server_config]
reduce_limit = false
-While disabling ``reduce_limit`` might be useful for debug proposes, remember,
-that main task of reduce functions is to *reduce* mapped result, not to make it
-even bigger. Generally, your reduce function should converge rapidly to a single
+While disabling ``reduce_limit`` might be useful for debug proposes, remember
+that the main task of reduce functions is to *reduce* mapped result, not to make
+them bigger. Generally, your reduce function should converge rapidly to a single
--- End diff --
LGFM, thanks! (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation pull request: A number of documentation fixe...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-documentation/pull/27#discussion_r37331199
--- Diff: src/couchapp/ddocs.rst ---
@@ -93,23 +92,23 @@ Reduce and rereduce functions
:return: Reduces `values`
Reduce functions takes two required arguments of keys and values lists - the
-result of the related map function - and optional third one which indicates if
-`rereduce` mode is active or not. `Rereduce` is using for additional reduce
+result of the related map function - and an optional third value which indicates
+if `rereduce` mode is active or not. `Rereduce` is used for additional reduce
values list, so when it is ``true`` there is no information about related `keys`
(first argument is ``null``).
-Note, that if produced result by `reduce` function is longer than initial
+Note that if the result of a `reduce` function is longer than the initial
values list then a Query Server error will be raised. However, this behavior
-could be disabled by setting ``reduce_limit`` config option to ``false``:
+can be disabled by setting ``reduce_limit`` config option to ``false``:
.. code-block:: ini
[query_server_config]
reduce_limit = false
-While disabling ``reduce_limit`` might be useful for debug proposes, remember,
-that main task of reduce functions is to *reduce* mapped result, not to make it
-even bigger. Generally, your reduce function should converge rapidly to a single
+While disabling ``reduce_limit`` might be useful for debug proposes, remember
+that the main task of reduce functions is to *reduce* mapped result, not to make
+them bigger. Generally, your reduce function should converge rapidly to a single
--- End diff --
Why did you replace `it` with `them`? `it` originally was referenced to `result` which is singular while `them` now cannot do the same as it is plural.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation pull request: A number of documentation fixe...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-documentation/pull/27#discussion_r37334611
--- Diff: src/couchapp/ddocs.rst ---
@@ -93,23 +92,23 @@ Reduce and rereduce functions
:return: Reduces `values`
Reduce functions takes two required arguments of keys and values lists - the
-result of the related map function - and optional third one which indicates if
-`rereduce` mode is active or not. `Rereduce` is using for additional reduce
+result of the related map function - and an optional third value which indicates
+if `rereduce` mode is active or not. `Rereduce` is used for additional reduce
values list, so when it is ``true`` there is no information about related `keys`
(first argument is ``null``).
-Note, that if produced result by `reduce` function is longer than initial
+Note that if the result of a `reduce` function is longer than the initial
values list then a Query Server error will be raised. However, this behavior
-could be disabled by setting ``reduce_limit`` config option to ``false``:
+can be disabled by setting ``reduce_limit`` config option to ``false``:
.. code-block:: ini
[query_server_config]
reduce_limit = false
-While disabling ``reduce_limit`` might be useful for debug proposes, remember,
-that main task of reduce functions is to *reduce* mapped result, not to make it
-even bigger. Generally, your reduce function should converge rapidly to a single
+While disabling ``reduce_limit`` might be useful for debug proposes, remember
+that the main task of reduce functions is to *reduce* mapped result, not to make
+them bigger. Generally, your reduce function should converge rapidly to a single
--- End diff --
Feel free to improve wording if you think it could be clear (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation pull request: A number of documentation fixe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-documentation/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---