You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2009/06/05 05:45:07 UTC

[jira] Created: (HBASE-1484) commit log split writes files with newest edits first (since hbase-1430); should be other way round

commit log split writes files with newest edits first (since hbase-1430); should be other way round
---------------------------------------------------------------------------------------------------

                 Key: HBASE-1484
                 URL: https://issues.apache.org/jira/browse/HBASE-1484
             Project: Hadoop HBase
          Issue Type: Bug
            Reporter: stack
             Fix For: 0.20.0




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1484) commit log split writes files with newest edits first (since hbase-1430); should be other way round

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1484:
-------------------------

    Fix Version/s:     (was: 0.20.0)
                   0.19.4

> commit log split writes files with newest edits first (since hbase-1430); should be other way round
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1484
>                 URL: https://issues.apache.org/jira/browse/HBASE-1484
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.19.4
>
>         Attachments: 1484.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1484) commit log split writes files with newest edits first (since hbase-1430); should be other way round

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1484:
-------------------------

    Attachment: 1484.patch

Fix for wrong order of edits.

M src/test/org/apache/hadoop/hbase/regionserver/TestHLog.java
  Added simple test that verifies only single region in a produced
  split file and that edits are in ascending order.
M src/java/org/apache/hadoop/hbase/regionserver/HLog.java
  Make splitLog return List of split logs written -- helps in unit tests.
  Walk the LinkedList of edits in reverse so edits come out in the order
  in which they were added writing split file.
  Added toString to HLogEdit.

> commit log split writes files with newest edits first (since hbase-1430); should be other way round
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1484
>                 URL: https://issues.apache.org/jira/browse/HBASE-1484
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.20.0
>
>         Attachments: 1484.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-1484) commit log split writes files with newest edits first (since hbase-1430); should be other way round

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-1484.
--------------------------

    Resolution: Fixed

> commit log split writes files with newest edits first (since hbase-1430); should be other way round
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1484
>                 URL: https://issues.apache.org/jira/browse/HBASE-1484
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.20.0
>
>         Attachments: 1484.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HBASE-1484) commit log split writes files with newest edits first (since hbase-1430); should be other way round

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack reassigned HBASE-1484:
----------------------------

    Assignee: stack

> commit log split writes files with newest edits first (since hbase-1430); should be other way round
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1484
>                 URL: https://issues.apache.org/jira/browse/HBASE-1484
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.20.0
>
>         Attachments: 1484.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-1484) commit log split writes files with newest edits first (since hbase-1430); should be other way round

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-1484.
--------------------------

    Resolution: Fixed

Thanks Clint.  Applied your patch to branch (Trunk was fine).

> commit log split writes files with newest edits first (since hbase-1430); should be other way round
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1484
>                 URL: https://issues.apache.org/jira/browse/HBASE-1484
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.20.0
>
>         Attachments: 1484.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HBASE-1484) commit log split writes files with newest edits first (since hbase-1430); should be other way round

Posted by "Clint Morgan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Clint Morgan reopened HBASE-1484:
---------------------------------


I get a NPE:

java.lang.NullPointerException
	at org.apache.hadoop.hbase.regionserver.HLog$1.run(HLog.java:912)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:885)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:907)
	at java.lang.Thread.run(Thread.java:637)

This fixes it:

Index: src/java/org/apache/hadoop/hbase/regionserver/HLog.java
===================================================================
--- src/java/org/apache/hadoop/hbase/regionserver/HLog.java	(revision 782058)
+++ src/java/org/apache/hadoop/hbase/regionserver/HLog.java	(working copy)
@@ -888,7 +888,8 @@
                       SequenceFile.Writer w =
                         SequenceFile.createWriter(fs, conf, logfile,
                           HLogKey.class, HLogEdit.class, getCompressionType(conf));
-                      logWriters.put(key, new WriterAndPath(logfile, w));
+                      wap = new WriterAndPath(logfile, w);
+                      logWriters.put(key, wap);
                       if (LOG.isDebugEnabled()) {
                         LOG.debug("Creating new hlog file writer for path "
                             + logfile + " and region " + Bytes.toString(key));


> commit log split writes files with newest edits first (since hbase-1430); should be other way round
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1484
>                 URL: https://issues.apache.org/jira/browse/HBASE-1484
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.20.0
>
>         Attachments: 1484.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.