You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "shunping (via GitHub)" <gi...@apache.org> on 2024/10/10 19:13:42 UTC
[PR] Fix the snapshot publishing script [beam]
shunping opened a new pull request, #32744:
URL: https://github.com/apache/beam/pull/32744
Since setuptools 69.3.0, the distribution name of a package has been normalized according to https://packaging.python.org/en/latest/specifications/binary-distribution-format/#escaping-and-unicode to support PEP 625 (https://github.com/pypa/setuptools/commit/b0135f5097f32a27b7a14e2c6296ba14bcb4e10b).
In our case, the source and binary distribution name would be changed from `apache-beam` to `apache_beam`.
This PR is to fix the script for publishing python snapshot so that the file can be published to gcs.
fixes #32729
related thread: #30955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the snapshot publishing script [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #32744:
URL: https://github.com/apache/beam/pull/32744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the snapshot publishing script [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #32744:
URL: https://github.com/apache/beam/pull/32744#discussion_r1795994326
##########
sdks/python/scripts/run_snapshot_publish.sh:
##########
@@ -30,8 +30,10 @@ DEP_SNAPSHOT_FILE_NAME="beam-py-requirements-$time.txt"
# and located under Gradle build directory.
cd $WORKSPACE/sdks/python/build
-# Rename the file to be apache-beam-{VERSION}-{datetime}.tar.gz
-for file in "apache-beam-$VERSION*.tar.gz"; do
+# Rename the file to be apache_beam-{VERSION}-{datetime}.tar.gz
+# Notice that the distribution name of beam has been normalized as "apache_beam"
+# since setuptools 69.3.0.
+for file in "apache_beam-$VERSION*.tar.gz"; do
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the snapshot publishing script [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #32744:
URL: https://github.com/apache/beam/pull/32744#discussion_r1795976010
##########
sdks/python/scripts/run_snapshot_publish.sh:
##########
@@ -30,8 +30,10 @@ DEP_SNAPSHOT_FILE_NAME="beam-py-requirements-$time.txt"
# and located under Gradle build directory.
cd $WORKSPACE/sdks/python/build
-# Rename the file to be apache-beam-{VERSION}-{datetime}.tar.gz
-for file in "apache-beam-$VERSION*.tar.gz"; do
+# Rename the file to be apache_beam-{VERSION}-{datetime}.tar.gz
+# Notice that the distribution name of beam has been normalized as "apache_beam"
+# since setuptools 69.3.0.
+for file in "apache_beam-$VERSION*.tar.gz"; do
Review Comment:
shall we use `apache?beam-$VERSION*` so both are supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the snapshot publishing script [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32744:
URL: https://github.com/apache/beam/pull/32744#issuecomment-2405871281
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the snapshot publishing script [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #32744:
URL: https://github.com/apache/beam/pull/32744#discussion_r1795977778
##########
sdks/python/scripts/run_snapshot_publish.sh:
##########
@@ -30,8 +30,10 @@ DEP_SNAPSHOT_FILE_NAME="beam-py-requirements-$time.txt"
# and located under Gradle build directory.
cd $WORKSPACE/sdks/python/build
-# Rename the file to be apache-beam-{VERSION}-{datetime}.tar.gz
-for file in "apache-beam-$VERSION*.tar.gz"; do
+# Rename the file to be apache_beam-{VERSION}-{datetime}.tar.gz
+# Notice that the distribution name of beam has been normalized as "apache_beam"
+# since setuptools 69.3.0.
+for file in "apache_beam-$VERSION*.tar.gz"; do
Review Comment:
Good point, I thought we pinned the setuptools, but we do not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the snapshot publishing script [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #32744:
URL: https://github.com/apache/beam/pull/32744#issuecomment-2405867195
r: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org