You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/08/23 14:09:31 UTC
[GitHub] [activemq] mattrpav opened a new pull request #701: [AMQ-8033] Remove activemq-camel
mattrpav opened a new pull request #701:
URL: https://github.com/apache/activemq/pull/701
- Prerequisite for JMS v2.0 support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] michaelandrepearce commented on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-904932385
This is a large feature removal (break for existing use base) has this been voted on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] mattrpav commented on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
mattrpav commented on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-908426916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] michaelpearce-gain edited a comment on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain edited a comment on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-909197370
> Bonus though! This change also opes up the ability for ActiveMQ to ship Camel 3.x in the future-- which many of those same users will start demanding as Camel 2.x ages out.
This is confusing me somewhat, let me explain some of my understanding and maybe you can correct me where wrong.
1) Today we ship ActiveMQ with Camel 2.x NOT 3.x
2) Out the box based on 1) users are able to have camel routes deployed within ActiveMQ process
3) The code in this PR is needed for Camel 2.x
4) You're removing Camel 2.x support BUT does not add Camel 3.x
Based on this we are essentially removing camel from within the broker, this is a massive feature removal, has this had PMC vote?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] mattrpav commented on a change in pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
mattrpav commented on a change in pull request #701:
URL: https://github.com/apache/activemq/pull/701#discussion_r694008630
##########
File path: activemq-osgi/pom.xml
##########
@@ -161,7 +161,6 @@
javax.servlet*;resolution:=optional,
com.thoughtworks.xstream*;resolution:=optional,
org.apache.activeio*;resolution:=optional,
- org.apache.activemq.camel*;resolution:=optional,
org.apache.camel*;version="${camel-version-range}";resolution:=optional,
Review comment:
@jbonofre considered removing all org.apache.camel imports here, but left them in case someone had embedded routes in the activemq.xml. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] mattrpav edited a comment on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
mattrpav edited a comment on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-904969004
> My comment was in regards to removal of out the box camel in the broker. The ticket original was about just upgrade not removal for it to be supported out the box.
What do you mean by 'out the box camel in the broker' removal? Camel jars are present in the assembly, as is the camel.xml sample-- which has been converted to use camel-jms in this PR.
> I am aware of user bases dependent on it being there, out the box.
Yep, same here. Users will have plenty of time to adapt given 5.16.x maintaining the as-is Camel 2.x support, and 5.17.x will contain the change. Same as JDK or JEE jar changes. Users can decided when to pull in updated versions of frameworks and their transitive impacts.
Bonus though! This change also opes up the ability for ActiveMQ to ship Camel 3.x in the future-- which many of those same users will start demanding as Camel 2.x ages out.
> Also just because a ticket is raised doesnt mean its been voted on.
@jbonofre mailed activemq-dev ~3 mos ago. See message subject: "[PROPOSAL] Remove activemq-camel from Apache ActiveMQ"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] michaelpearce-gain edited a comment on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain edited a comment on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-909197370
> Bonus though! This change also opes up the ability for ActiveMQ to ship Camel 3.x in the future-- which many of those same users will start demanding as Camel 2.x ages out.
This is confusing me somewhat, let me explain some of my understanding and maybe you can correct me where wrong.
1) Today we ship ActiveMQ with Camel 2.x NOT 3.x
2) Out the box based on 1) users are able to have camel routes deployed within ActiveMQ process
3) The code in this PR is needed for Camel 2.x
4) You're removing Camel 2.x support BUT does not add Camel 3.x
Based on this we are essentially removing camel from within the broker, this is a massive feature removal, has this had PMC vote?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] michaelpearce-gain commented on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-909197370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] michaelpearce-gain commented on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-909197370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] mattrpav commented on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
mattrpav commented on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-904969004
> My comment was in regards to removal of out the box camel in the broker. The ticket original was about just upgrade not removal for it to be supported out the box.
What do you mean by 'out the box camel in the broker' removal? Camel jars are present in the assembly, as is the camel.xml sample-- which has been converted to use camel-jms in this PR.
> I am aware of user bases dependent on it being there, out the box.
Yep, same here. Users will have plenty of time to adapt given 5.16.x maintaining the as-is Camel 2.x support, and 5.17.x will contain the change. Same as JDK or JEE jar changes. Users can decided when to pull in updated versions of frameworks.
This change also opens up the ability for ActiveMQ to ship Camel 3.x in the future-- which many of those same users will start demanding as Camel 2.x ages out.
> Also just because a ticket is raised doesnt mean its been voted on.
@jbonofre mailed activemq-dev ~3 mos ago. See message subject: "[PROPOSAL] Remove activemq-camel from Apache ActiveMQ"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] michaelandrepearce commented on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-904933801
I would have thought rather than removal upgrade should have been a less aggressive change. Im fairly certain camel is jms 2 compatible in latest versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] michaelpearce-gain edited a comment on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain edited a comment on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-909197370
> Bonus though! This change also opes up the ability for ActiveMQ to ship Camel 3.x in the future-- which many of those same users will start demanding as Camel 2.x ages out.
This is confusing me somewhat, let me explain some of my understanding and maybe you can correct me where wrong.
1) Today we ship ActiveMQ with Camel 2.x NOT 3.x
2) Out the box based on 1) users are able to have camel routes deployed within ActiveMQ process
3) The code in this PR is needed for Camel 2.x
4) You're removing Camel 2.x support BUT does not add Camel 3.x
Based on this we are essentially removing camel from within the broker, this is a massive feature removal, has this had PMC vote?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] mattrpav merged pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
mattrpav merged pull request #701:
URL: https://github.com/apache/activemq/pull/701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] michaelandrepearce commented on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-904962533
My comment was in regards to removal of out the box camel in the broker. The ticket original was about just upgrade not removal for it to be supported out the box.
I am aware of user bases dependent on it being there, out the box.
Also just because a ticket is raised doesnt mean its been voted on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] mattrpav edited a comment on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
mattrpav edited a comment on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-904969004
> My comment was in regards to removal of out the box camel in the broker. The ticket original was about just upgrade not removal for it to be supported out the box.
What do you mean by 'out the box camel in the broker' removal? Camel jars are present in the assembly, as is the camel.xml sample-- which has been converted to use camel-jms in this PR.
> I am aware of user bases dependent on it being there, out the box.
Yep, same here. Users will have plenty of time to adapt given 5.16.x maintaining the as-is Camel 2.x support, and 5.17.x will contain the change. Same as JDK or JEE/Jakarta changes. Users can decided when to pull in updated versions of frameworks and their transitive impacts.
Bonus though! This change also opes up the ability for ActiveMQ to ship Camel 3.x in the future-- which many of those same users will start demanding as Camel 2.x ages out.
> Also just because a ticket is raised doesnt mean its been voted on.
@jbonofre mailed activemq-dev ~3 mos ago. See message subject: "[PROPOSAL] Remove activemq-camel from Apache ActiveMQ"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] mattrpav commented on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
mattrpav commented on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-909213019
> This is confusing me somewhat, let me explain some of my understanding and maybe you can correct me where wrong.
>
> 1. Today we ship ActiveMQ with Camel 2.x NOT 3.x
Correct
> 2. Out the box based on 1) users are able to have camel routes deployed within ActiveMQ process
Correct
> 3. The code in this PR is needed for Camel 2.x
Incorrect. This PR removes the 'activemq-camel' Camel Component *only*. We still ship Camel 2.x, and this PR update the samples to use o.a.camel.component.jms.JmsComponent instead of o.a.activemq.camel.component.ActiveMQComponent.
see: [Component change](https://github.com/apache/activemq/pull/701/files#diff-1f1cf78427185d2d7a6eb9e106b9e73cbb786ea1d1eb849d3545af2e8497b438L53)
Note: ActiveMQComponent extends from JmsComponent
> 4. You're removing Camel 2.x support BUT does not add Camel 3.x
Incorrect. This PR removes just the 'activemq-camel' component, which has been repackaged by Camel as 'camel-activemq' for 3.x
Note: This change is a pre-req for Camel 3.x support as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] michaelpearce-gain commented on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-909197370
> Bonus though! This change also opes up the ability for ActiveMQ to ship Camel 3.x in the future-- which many of those same users will start demanding as Camel 2.x ages out.
This is confusing me somewhat, let me explain some of my understanding and maybe you can correct me where wrong.
1) Today we ship ActiveMQ with Camel 2.x NOT 3.x
2) Out the box based on 1) users are able to have camel routes deployed within ActiveMQ process
3) The code in this PR is needed for Camel 2.x
3) You're removing Camel 2.x support BUT does not add Camel 3.x
Based on this we are essentially removing camel from within the broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] mattrpav edited a comment on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
mattrpav edited a comment on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-904969004
> My comment was in regards to removal of out the box camel in the broker. The ticket original was about just upgrade not removal for it to be supported out the box.
What do you mean by 'out the box camel in the broker' removal? Camel jars are present in the assembly, as is the camel.xml sample-- which has been converted to use camel-jms in this PR.
> I am aware of user bases dependent on it being there, out the box.
Yep, same here. Users will have plenty of time to adapt given 5.16.x maintaining the as-is Camel 2.x support, and 5.17.x will contain the change. Same as JDK or JEE/Jakarta changes. Users can decided when to pull in updated versions of frameworks and their transitive impacts.
Bonus though! This change also opes up the ability for ActiveMQ to ship Camel 3.x in the future-- which many of those same users will start demanding as Camel 2.x ages out.
> Also just because a ticket is raised doesnt mean its been voted on.
@jbonofre mailed activemq-dev ~3 mos ago. See message on 2021/05/21 subject: "[PROPOSAL] Remove activemq-camel from Apache ActiveMQ"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] mattrpav commented on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
mattrpav commented on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-908426916
@michaelandrepearce good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] mattrpav commented on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
mattrpav commented on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-909213019
> This is confusing me somewhat, let me explain some of my understanding and maybe you can correct me where wrong.
>
> 1. Today we ship ActiveMQ with Camel 2.x NOT 3.x
Correct
> 2. Out the box based on 1) users are able to have camel routes deployed within ActiveMQ process
Correct
> 3. The code in this PR is needed for Camel 2.x
Incorrect. This PR removes the 'activemq-camel' Camel Component *only*. We still ship Camel 2.x, and this PR update the samples to use o.a.camel.component.jms.JmsComponent instead of o.a.activemq.camel.component.ActiveMQComponent.
see: [Component change](https://github.com/apache/activemq/pull/701/files#diff-1f1cf78427185d2d7a6eb9e106b9e73cbb786ea1d1eb849d3545af2e8497b438L53)
Note: ActiveMQComponent extends from JmsComponent
> 4. You're removing Camel 2.x support BUT does not add Camel 3.x
Incorrect. This PR removes just the 'activemq-camel' component, which has been repackaged by Camel as 'camel-activemq' for 3.x
Note: This change is a pre-req for Camel 3.x support as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] michaelpearce-gain commented on pull request #701: [AMQ-8033] Remove activemq-camel
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on pull request #701:
URL: https://github.com/apache/activemq/pull/701#issuecomment-909217059
Ok thanks, thanks for clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org