You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by GitBox <gi...@apache.org> on 2021/10/29 02:32:16 UTC
[GitHub] [turbine-archetypes] youngho1203 opened a new pull request #2: add ko_Kr localized sample
youngho1203 opened a new pull request #2:
URL: https://github.com/apache/turbine-archetypes/pull/2
add ko_Kr localized sample
and remove '*' in the en_US.properties. #* will consider as comment by velocity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org
[GitHub] [turbine-archetypes] gmkll merged pull request #2: add ko_Kr localized sample
Posted by GitBox <gi...@apache.org>.
gmkll merged pull request #2:
URL: https://github.com/apache/turbine-archetypes/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org
[GitHub] [turbine-archetypes] youngho1203 commented on pull request #2: add ko_Kr localized sample
Posted by GitBox <gi...@apache.org>.
youngho1203 commented on pull request #2:
URL: https://github.com/apache/turbine-archetypes/pull/2#issuecomment-955084529
I update TurbineResources.properties also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org
[GitHub] [turbine-archetypes] gmkll commented on pull request #2: add ko_Kr localized sample
Posted by GitBox <gi...@apache.org>.
gmkll commented on pull request #2:
URL: https://github.com/apache/turbine-archetypes/pull/2#issuecomment-956343618
tested to be correct, we may also activate utf-8 by default in archetype. My vote: +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org
[GitHub] [turbine-archetypes] gmkll commented on pull request #2: add ko_Kr localized sample
Posted by GitBox <gi...@apache.org>.
gmkll commented on pull request #2:
URL: https://github.com/apache/turbine-archetypes/pull/2#issuecomment-956343618
tested to be correct, we may also activate utf-8 by default in archetype. My vote: +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org
[GitHub] [turbine-archetypes] gmkll merged pull request #2: add ko_Kr localized sample
Posted by GitBox <gi...@apache.org>.
gmkll merged pull request #2:
URL: https://github.com/apache/turbine-archetypes/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org
[GitHub] [turbine-archetypes] gmkll merged pull request #2: add ko_Kr localized sample
Posted by GitBox <gi...@apache.org>.
gmkll merged pull request #2:
URL: https://github.com/apache/turbine-archetypes/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org
[GitHub] [turbine-archetypes] gmkll commented on pull request #2: add ko_Kr localized sample
Posted by GitBox <gi...@apache.org>.
gmkll commented on pull request #2:
URL: https://github.com/apache/turbine-archetypes/pull/2#issuecomment-954793453
Thanks for this PR, we appreciate it very much! Java 8 requires still latin1 in props files, that is we have to convert it for our current Java 8 supporting Turbine archetype like this:
`native2ascii -encoding UTF-8 src/main/resources/archetype-resources/src/main/java/L10N_ko_KR.properties`
which outputs the utf-8 escaped characters - but unfortunately even then I could not read the characters in the browser, e.g. for `$l10n.l10nkey` just some question marks show up -?
IMO: As Java 9 and above support UTF-8 chars in properties files, though, we acknowledge the PR as-is, but wait merging it until we update to java 11 (and above) support -?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org
[GitHub] [turbine-archetypes] youngho1203 edited a comment on pull request #2: add ko_Kr localized sample
Posted by GitBox <gi...@apache.org>.
youngho1203 edited a comment on pull request #2:
URL: https://github.com/apache/turbine-archetypes/pull/2#issuecomment-955084529
I update TurbineResources.properties also
you should be see the beautiful korean character for $l10n.l10nkey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org