You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/02/11 13:07:47 UTC
[GitHub] [cloudstack] joseflauzino commented on a change in pull request #5984: Persistence of VM stats
joseflauzino commented on a change in pull request #5984:
URL: https://github.com/apache/cloudstack/pull/5984#discussion_r804631522
##########
File path: core/src/main/java/com/cloud/agent/api/VmStatsEntry.java
##########
@@ -20,151 +20,17 @@
package com.cloud.agent.api;
import com.cloud.vm.UserVmVO;
-import com.cloud.vm.VmStats;
-public class VmStatsEntry implements VmStats {
+public class VmStatsEntry extends VmStatsEntryBase {
Review comment:
@ravening yes
`VmStatsEntryBase` class represents the VM metrics. When persisting a stats collection, this class is converted to JSON and assigned to the `vm_stats_data` field of the `vm_stats` table. `VmStatsEntry` class (which extends `VmStatsEntryBase`) has an `UserVmVO` attribute that is used in another piece of code, but does not need to be included in a `vm_stats` table record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org