You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "suja s (JIRA)" <ji...@apache.org> on 2012/06/19 06:10:44 UTC

[jira] [Created] (ZOOKEEPER-1490) If the configured log directory does not exist zookeeper will not start. Better to create the directory and start

suja s created ZOOKEEPER-1490:
---------------------------------

             Summary:  If the configured log directory does not exist zookeeper will not start. Better to create the directory and start
                 Key: ZOOKEEPER-1490
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1490
             Project: ZooKeeper
          Issue Type: Bug
          Components: scripts
            Reporter: suja s
            Priority: Minor


if the configured log directory does not exists zookeeper will not start. Better to create the directory and start
in zkEnv.sh we can change as follows

if [ "x${ZOO_LOG_DIR}" = "x" ]
then
    ZOO_LOG_DIR="."
   else
    if [ ! -w "$ZOO_LOG_DIR" ] ; then
        mkdir -p "$ZOO_LOG_DIR"
    fi
fi
 



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1490) If the configured log directory does not exist zookeeper will not start. Better to create the directory and start

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396520#comment-13396520 ] 

Hadoop QA commented on ZOOKEEPER-1490:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12532506/ZOOKEEPER_1490.patch
  against trunk revision 1351541.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1098//console

This message is automatically generated.
                
>  If the configured log directory does not exist zookeeper will not start. Better to create the directory and start
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1490
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1490
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>            Reporter: suja s
>            Priority: Minor
>         Attachments: ZOOKEEPER_1490.patch
>
>
> if the configured log directory does not exists zookeeper will not start. Better to create the directory and start
> in zkEnv.sh we can change as follows
> if [ "x${ZOO_LOG_DIR}" = "x" ]
> then
>     ZOO_LOG_DIR="."
>    else
>     if [ ! -w "$ZOO_LOG_DIR" ] ; then
>         mkdir -p "$ZOO_LOG_DIR"
>     fi
> fi
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (ZOOKEEPER-1490) If the configured log directory does not exist zookeeper will not start. Better to create the directory and start

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt reassigned ZOOKEEPER-1490:
---------------------------------------

    Assignee: suja s
    
>  If the configured log directory does not exist zookeeper will not start. Better to create the directory and start
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1490
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1490
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>            Reporter: suja s
>            Assignee: suja s
>            Priority: Minor
>         Attachments: ZOOKEEPER_1490.patch, ZOOKEEPER_1490.patch
>
>
> if the configured log directory does not exists zookeeper will not start. Better to create the directory and start
> in zkEnv.sh we can change as follows
> if [ "x${ZOO_LOG_DIR}" = "x" ]
> then
>     ZOO_LOG_DIR="."
>    else
>     if [ ! -w "$ZOO_LOG_DIR" ] ; then
>         mkdir -p "$ZOO_LOG_DIR"
>     fi
> fi
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1490) If the configured log directory does not exist zookeeper will not start. Better to create the directory and start

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398339#comment-13398339 ] 

Hadoop QA commented on ZOOKEEPER-1490:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12532854/ZOOKEEPER_1490_updated.patch
  against trunk revision 1351541.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1105//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1105//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1105//console

This message is automatically generated.
                
>  If the configured log directory does not exist zookeeper will not start. Better to create the directory and start
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1490
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1490
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>            Reporter: suja s
>            Assignee: suja s
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER_1490.patch, ZOOKEEPER_1490.patch, ZOOKEEPER_1490_updated.patch
>
>
> if the configured log directory does not exists zookeeper will not start. Better to create the directory and start
> in zkEnv.sh we can change as follows
> if [ "x${ZOO_LOG_DIR}" = "x" ]
> then
>     ZOO_LOG_DIR="."
>    else
>     if [ ! -w "$ZOO_LOG_DIR" ] ; then
>         mkdir -p "$ZOO_LOG_DIR"
>     fi
> fi
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1490) If the configured log directory does not exist zookeeper will not start. Better to create the directory and start

Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399005#comment-13399005 ] 

Roman Shaposhnik commented on ZOOKEEPER-1490:
---------------------------------------------

Looks good to me.
                
>  If the configured log directory does not exist zookeeper will not start. Better to create the directory and start
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1490
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1490
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>            Reporter: suja s
>            Assignee: suja s
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER_1490.patch, ZOOKEEPER_1490.patch, ZOOKEEPER_1490_updated.patch
>
>
> if the configured log directory does not exists zookeeper will not start. Better to create the directory and start
> in zkEnv.sh we can change as follows
> if [ "x${ZOO_LOG_DIR}" = "x" ]
> then
>     ZOO_LOG_DIR="."
>    else
>     if [ ! -w "$ZOO_LOG_DIR" ] ; then
>         mkdir -p "$ZOO_LOG_DIR"
>     fi
> fi
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1490) If the configured log directory does not exist zookeeper will not start. Better to create the directory and start

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404447#comment-13404447 ] 

Hudson commented on ZOOKEEPER-1490:
-----------------------------------

Integrated in ZooKeeper-trunk #1600 (See [https://builds.apache.org/job/ZooKeeper-trunk/1600/])
    ZOOKEEPER-1490. If the configured log directory does not exist zookeeper will not start. Better to create the directory and start (suja s via phunt) (Revision 1355641)

     Result = SUCCESS
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355641
Files : 
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/bin/zkServer.sh

                
>  If the configured log directory does not exist zookeeper will not start. Better to create the directory and start
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1490
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1490
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>            Reporter: suja s
>            Assignee: suja s
>            Priority: Minor
>             Fix For: 3.4.4, 3.5.0
>
>         Attachments: ZOOKEEPER_1490.patch, ZOOKEEPER_1490.patch, ZOOKEEPER_1490_updated.patch
>
>
> if the configured log directory does not exists zookeeper will not start. Better to create the directory and start
> in zkEnv.sh we can change as follows
> if [ "x${ZOO_LOG_DIR}" = "x" ]
> then
>     ZOO_LOG_DIR="."
>    else
>     if [ ! -w "$ZOO_LOG_DIR" ] ; then
>         mkdir -p "$ZOO_LOG_DIR"
>     fi
> fi
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1490) If the configured log directory does not exist zookeeper will not start. Better to create the directory and start

Posted by "suja s (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

suja s updated ZOOKEEPER-1490:
------------------------------

    Attachment: ZOOKEEPER_1490.patch

Attaching patch
                
>  If the configured log directory does not exist zookeeper will not start. Better to create the directory and start
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1490
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1490
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>            Reporter: suja s
>            Priority: Minor
>         Attachments: ZOOKEEPER_1490.patch
>
>
> if the configured log directory does not exists zookeeper will not start. Better to create the directory and start
> in zkEnv.sh we can change as follows
> if [ "x${ZOO_LOG_DIR}" = "x" ]
> then
>     ZOO_LOG_DIR="."
>    else
>     if [ ! -w "$ZOO_LOG_DIR" ] ; then
>         mkdir -p "$ZOO_LOG_DIR"
>     fi
> fi
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1490) If the configured log directory does not exist zookeeper will not start. Better to create the directory and start

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396570#comment-13396570 ] 

Hadoop QA commented on ZOOKEEPER-1490:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12532511/ZOOKEEPER_1490.patch
  against trunk revision 1351541.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1099//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1099//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1099//console

This message is automatically generated.
                
>  If the configured log directory does not exist zookeeper will not start. Better to create the directory and start
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1490
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1490
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>            Reporter: suja s
>            Priority: Minor
>         Attachments: ZOOKEEPER_1490.patch, ZOOKEEPER_1490.patch
>
>
> if the configured log directory does not exists zookeeper will not start. Better to create the directory and start
> in zkEnv.sh we can change as follows
> if [ "x${ZOO_LOG_DIR}" = "x" ]
> then
>     ZOO_LOG_DIR="."
>    else
>     if [ ! -w "$ZOO_LOG_DIR" ] ; then
>         mkdir -p "$ZOO_LOG_DIR"
>     fi
> fi
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1490) If the configured log directory does not exist zookeeper will not start. Better to create the directory and start

Posted by "Rakesh R (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396527#comment-13396527 ] 

Rakesh R commented on ZOOKEEPER-1490:
-------------------------------------

@Suja

bq. -1 patch.  The patch command could not apply the patch.

Here the patch has been generated directly from the modified file, instead please generate patch from the zk home.

Please visit the following link for more understanding:
http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute


                
>  If the configured log directory does not exist zookeeper will not start. Better to create the directory and start
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1490
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1490
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>            Reporter: suja s
>            Priority: Minor
>         Attachments: ZOOKEEPER_1490.patch
>
>
> if the configured log directory does not exists zookeeper will not start. Better to create the directory and start
> in zkEnv.sh we can change as follows
> if [ "x${ZOO_LOG_DIR}" = "x" ]
> then
>     ZOO_LOG_DIR="."
>    else
>     if [ ! -w "$ZOO_LOG_DIR" ] ; then
>         mkdir -p "$ZOO_LOG_DIR"
>     fi
> fi
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1490) If the configured log directory does not exist zookeeper will not start. Better to create the directory and start

Posted by "suja s (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

suja s updated ZOOKEEPER-1490:
------------------------------

    Attachment: ZOOKEEPER_1490_updated.patch

Thank You for taking a look. Attaching updated patch.
                
>  If the configured log directory does not exist zookeeper will not start. Better to create the directory and start
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1490
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1490
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>            Reporter: suja s
>            Assignee: suja s
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER_1490.patch, ZOOKEEPER_1490.patch, ZOOKEEPER_1490_updated.patch
>
>
> if the configured log directory does not exists zookeeper will not start. Better to create the directory and start
> in zkEnv.sh we can change as follows
> if [ "x${ZOO_LOG_DIR}" = "x" ]
> then
>     ZOO_LOG_DIR="."
>    else
>     if [ ! -w "$ZOO_LOG_DIR" ] ; then
>         mkdir -p "$ZOO_LOG_DIR"
>     fi
> fi
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1490) If the configured log directory does not exist zookeeper will not start. Better to create the directory and start

Posted by "suja s (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

suja s updated ZOOKEEPER-1490:
------------------------------

    Attachment: ZOOKEEPER_1490.patch

Attaching the updated patch
                
>  If the configured log directory does not exist zookeeper will not start. Better to create the directory and start
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1490
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1490
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>            Reporter: suja s
>            Priority: Minor
>         Attachments: ZOOKEEPER_1490.patch, ZOOKEEPER_1490.patch
>
>
> if the configured log directory does not exists zookeeper will not start. Better to create the directory and start
> in zkEnv.sh we can change as follows
> if [ "x${ZOO_LOG_DIR}" = "x" ]
> then
>     ZOO_LOG_DIR="."
>    else
>     if [ ! -w "$ZOO_LOG_DIR" ] ; then
>         mkdir -p "$ZOO_LOG_DIR"
>     fi
> fi
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira