[jira] [Commented] (TEPHRA-287) ActionChange.getChangeKey() not implemented correctly

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEPHRA-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427430#comment-16427430 ] 

James Taylor commented on TEPHRA-287:
-------------------------------------

bq. f all the clients are not upgraded simultaneously then we may miss some conflicts due to the change set encoding change. Any thoughts on how to handle this?
Good point. The only thing I can think of would be to have a new config property that enables the new change set encoding. When not set, the old encoding scheme would be used. The config would be enabled only after knowing that all clients have been upgraded. I can implement this if you think it's a reasonable approach.

> ActionChange.getChangeKey() not implemented correctly
> -----------------------------------------------------
>
>                 Key: TEPHRA-287
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-287
>             Project: Tephra
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 0.14.0-incubating
>
>         Attachments: TEPHRA-287_v1.patch, TEPHRA-287_v2.patch
>
>
> The ActionChange.getChangeKey() simply concatenates together the row key, family, and qualifier which could lead to incorrect conflicting keys. For example (rowKey='a', family='bc') would conflict with (rowKey='ab', family='c'). A simple fix would be to prefix each part with the byte length of each part.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)