You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2022/07/14 17:00:32 UTC
Change in asterixdb[neo]: Add overridable clean up step after dropping a dataverse
From Hussain Towaileb <hu...@gmail.com>:
Hussain Towaileb has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943 )
Change subject: Add overridable clean up step after dropping a dataverse
......................................................................
Add overridable clean up step after dropping a dataverse
Change-Id: Ic0e4997f22e3c24dc0a3fafe5a44ef8a960a6dff
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/16943/1
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
index 41d9282..1729b50 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
@@ -2035,6 +2035,8 @@
if (activeDataverse.getDataverseName().equals(dataverseName)) {
activeDataverse = MetadataBuiltinEntities.DEFAULT_DATAVERSE;
}
+
+ validateDataverseDatasetsStateAfterDrop(metadataProvider, mdTxnCtx, datasets);
MetadataManager.INSTANCE.commitTransaction(mdTxnCtx);
return true;
} catch (Exception e) {
@@ -2081,7 +2083,12 @@
protected void validateDataverseStateBeforeDrop(MetadataProvider metadataProvider, Dataverse dataverse,
SourceLocation sourceLoc) throws AlgebricksException {
- // may be overriden by product extensions for additional checks before dropping the dataverse
+ // may be overridden by product extensions for additional checks before dropping the dataverse
+ }
+
+ protected void validateDataverseDatasetsStateAfterDrop(MetadataProvider metadataProvider,
+ MetadataTransactionContext mdTxnCtx, List<Dataset> datasets) throws AlgebricksException {
+ // may be overridden by product extensions for additional checks after dropping the dataverse
}
public void handleDatasetDropStatement(MetadataProvider metadataProvider, Statement stmt,
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ic0e4997f22e3c24dc0a3fafe5a44ef8a960a6dff
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-MessageType: newchange
Change in asterixdb[neo]: Add overridable clean up step after dropping a dataverse
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Michael Blow <mb...@apache.org>:
Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943 )
Change subject: Add overridable clean up step after dropping a dataverse
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ic0e4997f22e3c24dc0a3fafe5a44ef8a960a6dff
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Comment-Date: Thu, 14 Jul 2022 23:09:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[neo]: Add overridable clean up step after dropping a dataverse
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Hussain Towaileb <hu...@gmail.com>:
Hussain Towaileb has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943 )
Change subject: Add overridable clean up step after dropping a dataverse
......................................................................
Add overridable clean up step after dropping a dataverse
Change-Id: Ic0e4997f22e3c24dc0a3fafe5a44ef8a960a6dff
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/16943/1
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
index 41d9282..1729b50 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
@@ -2035,6 +2035,8 @@
if (activeDataverse.getDataverseName().equals(dataverseName)) {
activeDataverse = MetadataBuiltinEntities.DEFAULT_DATAVERSE;
}
+
+ validateDataverseDatasetsStateAfterDrop(metadataProvider, mdTxnCtx, datasets);
MetadataManager.INSTANCE.commitTransaction(mdTxnCtx);
return true;
} catch (Exception e) {
@@ -2081,7 +2083,12 @@
protected void validateDataverseStateBeforeDrop(MetadataProvider metadataProvider, Dataverse dataverse,
SourceLocation sourceLoc) throws AlgebricksException {
- // may be overriden by product extensions for additional checks before dropping the dataverse
+ // may be overridden by product extensions for additional checks before dropping the dataverse
+ }
+
+ protected void validateDataverseDatasetsStateAfterDrop(MetadataProvider metadataProvider,
+ MetadataTransactionContext mdTxnCtx, List<Dataset> datasets) throws AlgebricksException {
+ // may be overridden by product extensions for additional checks after dropping the dataverse
}
public void handleDatasetDropStatement(MetadataProvider metadataProvider, Statement stmt,
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ic0e4997f22e3c24dc0a3fafe5a44ef8a960a6dff
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-MessageType: newchange
Change in asterixdb[neo]: Add overridable clean up step after dropping a dataverse
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943 )
Change subject: Add overridable clean up step after dropping a dataverse
......................................................................
Patch Set 1:
Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/Y7WoT119eFdzwYK29 : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ic0e4997f22e3c24dc0a3fafe5a44ef8a960a6dff
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 14 Jul 2022 17:10:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in asterixdb[neo]: Add overridable clean up step after dropping a dataverse
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Hussain Towaileb <hu...@gmail.com>:
Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943 )
Change subject: Add overridable clean up step after dropping a dataverse
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ic0e4997f22e3c24dc0a3fafe5a44ef8a960a6dff
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Comment-Date: Thu, 14 Jul 2022 20:07:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[neo]: Add overridable clean up step after dropping a dataverse
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Hussain Towaileb <hu...@gmail.com>:
Hussain Towaileb has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943 )
Change subject: Add overridable clean up step after dropping a dataverse
......................................................................
Add overridable clean up step after dropping a dataverse
Change-Id: Ic0e4997f22e3c24dc0a3fafe5a44ef8a960a6dff
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Hussain Towaileb <hu...@gmail.com>
Reviewed-by: Michael Blow <mb...@apache.org>
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Michael Blow: Looks good to me, approved
Hussain Towaileb: Looks good to me, but someone else must approve
Jenkins: Verified; Verified
Anon. E. Moose #1000171:
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
index 41d9282..1729b50 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
@@ -2035,6 +2035,8 @@
if (activeDataverse.getDataverseName().equals(dataverseName)) {
activeDataverse = MetadataBuiltinEntities.DEFAULT_DATAVERSE;
}
+
+ validateDataverseDatasetsStateAfterDrop(metadataProvider, mdTxnCtx, datasets);
MetadataManager.INSTANCE.commitTransaction(mdTxnCtx);
return true;
} catch (Exception e) {
@@ -2081,7 +2083,12 @@
protected void validateDataverseStateBeforeDrop(MetadataProvider metadataProvider, Dataverse dataverse,
SourceLocation sourceLoc) throws AlgebricksException {
- // may be overriden by product extensions for additional checks before dropping the dataverse
+ // may be overridden by product extensions for additional checks before dropping the dataverse
+ }
+
+ protected void validateDataverseDatasetsStateAfterDrop(MetadataProvider metadataProvider,
+ MetadataTransactionContext mdTxnCtx, List<Dataset> datasets) throws AlgebricksException {
+ // may be overridden by product extensions for additional checks after dropping the dataverse
}
public void handleDatasetDropStatement(MetadataProvider metadataProvider, Statement stmt,
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ic0e4997f22e3c24dc0a3fafe5a44ef8a960a6dff
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 2
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-MessageType: merged
Change in asterixdb[neo]: Add overridable clean up step after dropping a dataverse
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943 )
Change subject: Add overridable clean up step after dropping a dataverse
......................................................................
Patch Set 1: Contrib+1
Analytics Compatibility Tests Successful
https://cbjenkins.page.link/PdbQM2Y1Q2TGfraVA : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ic0e4997f22e3c24dc0a3fafe5a44ef8a960a6dff
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 14 Jul 2022 19:05:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[neo]: Add overridable clean up step after dropping a dataverse
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Jenkins <je...@fulliautomatix.ics.uci.edu>:
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943 )
Change subject: Add overridable clean up step after dropping a dataverse
......................................................................
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/13271/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ic0e4997f22e3c24dc0a3fafe5a44ef8a960a6dff
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-Comment-Date: Thu, 14 Jul 2022 18:05:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment