You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/23 09:14:12 UTC
[GitHub] [inlong] yunqingmoswu opened a new pull request, #4754: [INLONG-4685][Sort] Optimize the metadata implementation of Extract Nodes and Load Nodes
yunqingmoswu opened a new pull request, #4754:
URL: https://github.com/apache/inlong/pull/4754
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title: [INLONG-4685][Sort] Optimize the metadata implementation of Extract Nodes and Load Nodes
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
Fixes #4751
### Motivation
Optimize the metadata implementation of Extract Nodes and Load Nodes
### Modifications
The metadata implementation of Extract Nodes and Load Nodes will be more elegant.
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [x] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] thesumery commented on pull request #4754: [INLONG-4751][Sort] Optimize the metadata implementation of Extract Nodes and Load Nodes
Posted by GitBox <gi...@apache.org>.
thesumery commented on PR #4754:
URL: https://github.com/apache/inlong/pull/4754#issuecomment-1165152219
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] yunqingmoswu commented on pull request #4754: [INLONG-4685][Sort] Optimize the metadata implementation of Extract Nodes and Load Nodes
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on PR #4754:
URL: https://github.com/apache/inlong/pull/4754#issuecomment-1164173732
1. Decouple node-supported metadata fields from Flink SQL Parser. Node update metadata field support without modifying Flink SQL Parser.
2. Increase the scalability of metadata field support. To support metadata fields, new nodes only need to implement the Metadata interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on pull request #4754: [INLONG-4685][Sort] Optimize the metadata implementation of Extract Nodes and Load Nodes
Posted by GitBox <gi...@apache.org>.
gong commented on PR #4754:
URL: https://github.com/apache/inlong/pull/4754#issuecomment-1164225346
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap merged pull request #4754: [INLONG-4751][Sort] Optimize the metadata implementation of Extract Nodes and Load Nodes
Posted by GitBox <gi...@apache.org>.
EMsnap merged PR #4754:
URL: https://github.com/apache/inlong/pull/4754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org