You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Kikyou1997 (via GitHub)" <gi...@apache.org> on 2023/11/14 06:22:55 UTC
[PR] [minor](stats) rename stats related session variable name [doris]
Kikyou1997 opened a new pull request, #26936:
URL: https://github.com/apache/doris/pull/26936
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](stats) rename stats related session variable name [doris]
Posted by "Kikyou1997 (via GitHub)" <gi...@apache.org>.
Kikyou1997 commented on PR #26936:
URL: https://github.com/apache/doris/pull/26936#issuecomment-1809613652
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](stats) rename stats related session variable name [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26936:
URL: https://github.com/apache/doris/pull/26936#issuecomment-1809699813
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](stats) rename stats related session variable name [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly merged PR #26936:
URL: https://github.com/apache/doris/pull/26936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](stats) rename stats related session variable name [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26936:
URL: https://github.com/apache/doris/pull/26936#issuecomment-1809724760
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 20ec9ec8c63c879e51c0d358355465a1e7b3c370, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5326 5126 5117 5117
q2 360 155 159 155
q3 2036 2017 2010 2010
q4 1413 1384 1361 1361
q5 3985 3950 3972 3950
q6 257 130 126 126
q7 1461 876 905 876
q8 2789 2776 2747 2747
q9 9593 9362 9569 9362
q10 3435 3537 3525 3525
q11 396 265 241 241
q12 450 280 281 280
q13 4568 4147 4110 4110
q14 320 311 284 284
q15 629 556 540 540
q16 669 599 576 576
q17 1115 1079 1082 1079
q18 8003 7618 7625 7618
q19 1676 1649 1665 1649
q20 527 300 295 295
q21 4699 4320 4361 4320
q22 528 407 411 407
Total cold run time: 54235 ms
Total hot run time: 50628 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 5053 5046 5078 5046
q2 338 227 243 227
q3 4047 4024 4049 4024
q4 2770 2754 2757 2754
q5 9829 9747 9768 9747
q6 246 119 120 119
q7 3030 2493 2470 2470
q8 4828 4820 4829 4820
q9 13123 12851 13053 12851
q10 4086 4169 4184 4169
q11 766 657 661 657
q12 1024 828 832 828
q13 4290 3843 3885 3843
q14 373 346 375 346
q15 637 561 569 561
q16 776 715 705 705
q17 3911 3889 3952 3889
q18 9660 9474 9552 9474
q19 1805 1786 1765 1765
q20 2424 2044 2041 2041
q21 8931 8583 8794 8583
q22 919 852 848 848
Total cold run time: 82866 ms
Total hot run time: 79767 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](stats) rename stats related session variable name [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #26936:
URL: https://github.com/apache/doris/pull/26936#discussion_r1395118236
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1260,17 +1260,12 @@ public void setMaxJoinNumberOfReorder(int maxJoinNumberOfReorder) {
+ " use a skiplist to optimize the intersection."})
public int invertedIndexConjunctionOptThreshold = 1000;
- @VariableMgr.VarAttr(name = FULL_AUTO_ANALYZE_START_TIME, needForward = true, checker = "checkAnalyzeTimeFormat",
- description = {"该参数定义自动ANALYZE例程的开始时间",
- "This parameter defines the start time for the automatic ANALYZE routine."},
- flag = VariableMgr.GLOBAL)
- public String fullAutoAnalyzeStartTime = "00:00:00";
- @VariableMgr.VarAttr(name = FULL_AUTO_ANALYZE_END_TIME, needForward = true, checker = "checkAnalyzeTimeFormat",
+ @VariableMgr.VarAttr(name = AUTO_ANALYZE_END_TIME, needForward = true, checker = "checkAnalyzeTimeFormat",
Review Comment:
put all auto analyze variable togather
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1286,10 +1281,16 @@ public void setMaxJoinNumberOfReorder(int maxJoinNumberOfReorder) {
options = {"none", "sql_cache", "partition_cache"})
public String testQueryCacheHit = "none";
- @VariableMgr.VarAttr(name = ENABLE_FULL_AUTO_ANALYZE,
+ @VariableMgr.VarAttr(name = ENABLE_AUTO_ANALYZE,
description = {"该参数控制是否开启自动收集", "Set false to disable auto analyze"},
flag = VariableMgr.GLOBAL)
- public boolean enableFullAutoAnalyze = true;
+ public boolean enableAutoAnalyze = false;
Review Comment:
```suggestion
public boolean enableAutoAnalyze = true;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](stats) rename stats related session variable name [doris]
Posted by "Kikyou1997 (via GitHub)" <gi...@apache.org>.
Kikyou1997 commented on PR #26936:
URL: https://github.com/apache/doris/pull/26936#issuecomment-1815834503
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](stats) rename stats related session variable name [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26936:
URL: https://github.com/apache/doris/pull/26936#issuecomment-1815953054
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 486394634b60abedba04e159a74d86249afcddc3, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4949 4665 4670 4665
q2 356 166 151 151
q3 2037 1906 1909 1906
q4 1401 1288 1247 1247
q5 3971 3970 4032 3970
q6 246 130 131 130
q7 1384 876 876 876
q8 2782 2815 2792 2792
q9 9751 9633 9532 9532
q10 3471 3572 3549 3549
q11 378 242 248 242
q12 435 298 291 291
q13 4624 3818 3757 3757
q14 313 286 284 284
q15 587 526 528 526
q16 659 590 576 576
q17 1146 971 937 937
q18 7893 7487 7409 7409
q19 1696 1685 1676 1676
q20 578 297 292 292
q21 4447 3952 3992 3952
q22 472 372 369 369
Total cold run time: 53576 ms
Total hot run time: 49129 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4577 4618 4611 4611
q2 355 237 260 237
q3 4039 4007 4005 4005
q4 2702 2695 2687 2687
q5 9674 9636 9638 9636
q6 241 120 120 120
q7 2605 2286 2251 2251
q8 4482 4457 4553 4457
q9 13161 13093 13058 13058
q10 4116 4204 4207 4204
q11 823 694 669 669
q12 971 813 809 809
q13 4265 3537 3532 3532
q14 404 351 351 351
q15 577 523 529 523
q16 738 666 681 666
q17 3886 3906 3974 3906
q18 9636 8885 9279 8885
q19 1822 1807 1782 1782
q20 2397 2042 2072 2042
q21 8804 8687 8929 8687
q22 912 824 786 786
Total cold run time: 81187 ms
Total hot run time: 77904 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](stats) rename stats related session variable name [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26936:
URL: https://github.com/apache/doris/pull/26936#issuecomment-1809738641
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.99 seconds
stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17097245351 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](stats) rename stats related session variable name [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26936:
URL: https://github.com/apache/doris/pull/26936#issuecomment-1815961846
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.03 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17098869678 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](stats) rename stats related session variable name [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26936:
URL: https://github.com/apache/doris/pull/26936#issuecomment-1818712732
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org