You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/01 13:24:46 UTC

[GitHub] [airflow] potiuk commented on pull request #21460: Add non-ascii character support in xcom table

potiuk commented on pull request #21460:
URL: https://github.com/apache/airflow/pull/21460#issuecomment-1055440054


   > I’m not sure this fixes anything. By default, `json.dumps()` uses `ensure_ascii=True` and produces Unicode codepoint escape sequences, which should be able to be saved in any database configured in any encoding. Changing to `ensure_ascii=False` just makes the JSON string being serialised into a different value that still has the same characteristics.
   > 
   > I suspect this is not the correct fix, and the right fix to the original issue should be to remove `encode("UTF-8")`.
   
   Agree. Closing it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org