You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/02/25 00:55:30 UTC

[GitHub] [trafficserver] maskit commented on a change in pull request #7559: Check verify policy and properties

maskit commented on a change in pull request #7559:
URL: https://github.com/apache/trafficserver/pull/7559#discussion_r582412883



##########
File path: iocore/net/SSLUtils.cc
##########
@@ -2065,6 +2062,54 @@ get_sni_addr(SSL *ssl)
   return sni_addr;
 }
 
+std::string
+get_verify_str(SSL *ssl)
+{
+  std::string verify_str;
+
+  SSLNetVConnection *netvc = SSLNetVCAccess(ssl);

Review comment:
       SSLNetVCAccess 😞 I don't see it as a blocker because QUIC connection to origin is probably years away, but we should try to avoid using it for new stuff.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org