You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2017/11/02 17:47:34 UTC
Review Request 63519: Allowed toggling of agent capabilities via
command line flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jan Schlicht.
Repository: mesos
Description
-------
This patch introduces a new agent command line flags
'--agent_features' which can be used to whitelist capabilities to
enable. This flag is intended to enable introducing feature flags in
the future so experimental features can be added while still reducing
the risk of breaking existing functionality. Currently only the
'RESOURCE_PROVIDER' capability can be toggled.
Diffs
-----
docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c
src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807
src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070
Diff: https://reviews.apache.org/r/63519/diff/1/
Testing
-------
`make check`, tested as part of https://reviews.apache.org/r/63496/
Thanks,
Benjamin Bannier
Re: Review Request 63519: Allowed toggling of agent capabilities via
command line flags.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/#review190044
-----------------------------------------------------------
src/slave/slave.hpp
Lines 574 (patched)
<https://reviews.apache.org/r/63519/#comment267297>
Can you re-use slave::Capabilities in protobuf_utils.cpp|hpp?
Also, given that this is already under `Slave`, i'd just call it `capabilities`. (more consistent with Framework::capabilities).
src/slave/slave.cpp
Lines 8441-8453 (patched)
<https://reviews.apache.org/r/63519/#comment267299>
Can you move this to the flag validation?
- Jie Yu
On Nov. 3, 2017, 4:06 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63519/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2017, 4:06 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch introduces a new agent command line flags
> '--agent_features' which can be used to whitelist capabilities to
> enable. This flag is intended to enable introducing feature flags in
> the future so experimental features can be added while still reducing
> the risk of breaking existing functionality. Currently only the
> 'RESOURCE_PROVIDER' capability can be toggled.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c
> src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
> src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807
> src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
> src/slave/slave.cpp 79ee163b41ade93cae1054985379d61faf6a081a
>
>
> Diff: https://reviews.apache.org/r/63519/diff/3/
>
>
> Testing
> -------
>
> `make check`, tested as part of https://reviews.apache.org/r/63496/
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 63519: Allowed toggling of agent capabilities via
command line flags.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/
-----------------------------------------------------------
(Updated Nov. 8, 2017, 12:35 a.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Updated docs.
Repository: mesos
Description
-------
This patch introduces a new agent command line flags
'--agent_features' which can be used to whitelist capabilities to
enable. This flag is intended to enable introducing feature flags in
the future so experimental features can be added while still reducing
the risk of breaking existing functionality. Currently only the
'RESOURCE_PROVIDER' capability can be toggled.
Diffs (updated)
-----
docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c
src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
src/slave/flags.cpp 63aaac218fdc067742d39f1fc8497723784d9595
src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
src/slave/slave.cpp c10823985154bac19f8952b94311a03b2b9b4ea1
Diff: https://reviews.apache.org/r/63519/diff/7/
Changes: https://reviews.apache.org/r/63519/diff/6-7/
Testing
-------
`make check`, tested as part of https://reviews.apache.org/r/63496/
Thanks,
Benjamin Bannier
Re: Review Request 63519: Allowed toggling of agent capabilities via
command line flags.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/#review190375
-----------------------------------------------------------
docs/configuration/agent.md
Lines 101-103 (patched)
<https://reviews.apache.org/r/63519/#comment267707>
Please update these.
src/slave/flags.cpp
Lines 653-655 (patched)
<https://reviews.apache.org/r/63519/#comment267708>
Ditto.
- Jie Yu
On Nov. 7, 2017, 10 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63519/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 10 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch introduces a new agent command line flags
> '--agent_features' which can be used to whitelist capabilities to
> enable. This flag is intended to enable introducing feature flags in
> the future so experimental features can be added while still reducing
> the risk of breaking existing functionality. Currently only the
> 'RESOURCE_PROVIDER' capability can be toggled.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c
> src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
> src/slave/flags.cpp 63aaac218fdc067742d39f1fc8497723784d9595
> src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
> src/slave/slave.cpp c10823985154bac19f8952b94311a03b2b9b4ea1
>
>
> Diff: https://reviews.apache.org/r/63519/diff/6/
>
>
> Testing
> -------
>
> `make check`, tested as part of https://reviews.apache.org/r/63496/
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 63519: Allowed toggling of agent capabilities via
command line flags.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/
-----------------------------------------------------------
(Updated Nov. 7, 2017, 11 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Addressed comment by Jie.
Repository: mesos
Description
-------
This patch introduces a new agent command line flags
'--agent_features' which can be used to whitelist capabilities to
enable. This flag is intended to enable introducing feature flags in
the future so experimental features can be added while still reducing
the risk of breaking existing functionality. Currently only the
'RESOURCE_PROVIDER' capability can be toggled.
Diffs (updated)
-----
docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c
src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
src/slave/flags.cpp 63aaac218fdc067742d39f1fc8497723784d9595
src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
src/slave/slave.cpp c10823985154bac19f8952b94311a03b2b9b4ea1
Diff: https://reviews.apache.org/r/63519/diff/6/
Changes: https://reviews.apache.org/r/63519/diff/5-6/
Testing
-------
`make check`, tested as part of https://reviews.apache.org/r/63496/
Thanks,
Benjamin Bannier
Re: Review Request 63519: Allowed toggling of agent capabilities via
command line flags.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/
-----------------------------------------------------------
(Updated Nov. 7, 2017, 1:25 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Addressed comments by Jie.
Repository: mesos
Description
-------
This patch introduces a new agent command line flags
'--agent_features' which can be used to whitelist capabilities to
enable. This flag is intended to enable introducing feature flags in
the future so experimental features can be added while still reducing
the risk of breaking existing functionality. Currently only the
'RESOURCE_PROVIDER' capability can be toggled.
Diffs (updated)
-----
docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c
src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807
src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
src/slave/slave.cpp 79ee163b41ade93cae1054985379d61faf6a081a
Diff: https://reviews.apache.org/r/63519/diff/5/
Changes: https://reviews.apache.org/r/63519/diff/4-5/
Testing
-------
`make check`, tested as part of https://reviews.apache.org/r/63496/
Thanks,
Benjamin Bannier
Re: Review Request 63519: Allowed toggling of agent capabilities via
command line flags.
Posted by Benjamin Bannier <bb...@apache.org>.
> On Nov. 7, 2017, 12:22 a.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Lines 8409 (patched)
> > <https://reviews.apache.org/r/63519/diff/4/?file=1881889#file1881889line8416>
> >
> > Do you need this. I thought `protobuf::slave::Capabilities` already has a constructor that takes a Iterable? Can you do:
> > ```
> > if (flags.agent_features.isNone()) {
> > return AGENT_CAPABILITIES();
> > }
> >
> > return flags.agent_features->capabilities();
> > ```
See my to your comments below.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/#review190245
-----------------------------------------------------------
On Nov. 7, 2017, 1:25 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63519/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 1:25 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch introduces a new agent command line flags
> '--agent_features' which can be used to whitelist capabilities to
> enable. This flag is intended to enable introducing feature flags in
> the future so experimental features can be added while still reducing
> the risk of breaking existing functionality. Currently only the
> 'RESOURCE_PROVIDER' capability can be toggled.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c
> src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
> src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807
> src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
> src/slave/slave.cpp 79ee163b41ade93cae1054985379d61faf6a081a
>
>
> Diff: https://reviews.apache.org/r/63519/diff/5/
>
>
> Testing
> -------
>
> `make check`, tested as part of https://reviews.apache.org/r/63496/
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 63519: Allowed toggling of agent capabilities via
command line flags.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/#review190245
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/main.cpp
Lines 375-395 (patched)
<https://reviews.apache.org/r/63519/#comment267544>
Can you move this to `add` method in src/slave/flags.cpp?
`add` takes a validation lambda.
src/slave/slave.cpp
Lines 8409 (patched)
<https://reviews.apache.org/r/63519/#comment267543>
Do you need this. I thought `protobuf::slave::Capabilities` already has a constructor that takes a Iterable? Can you do:
```
if (flags.agent_features.isNone()) {
return AGENT_CAPABILITIES();
}
return flags.agent_features->capabilities();
```
- Jie Yu
On Nov. 6, 2017, 12:39 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63519/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2017, 12:39 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch introduces a new agent command line flags
> '--agent_features' which can be used to whitelist capabilities to
> enable. This flag is intended to enable introducing feature flags in
> the future so experimental features can be added while still reducing
> the risk of breaking existing functionality. Currently only the
> 'RESOURCE_PROVIDER' capability can be toggled.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c
> src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
> src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807
> src/slave/main.cpp 94431b036524ef4db16a594c80f45b64a45728f7
> src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
> src/slave/slave.cpp 79ee163b41ade93cae1054985379d61faf6a081a
>
>
> Diff: https://reviews.apache.org/r/63519/diff/4/
>
>
> Testing
> -------
>
> `make check`, tested as part of https://reviews.apache.org/r/63496/
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 63519: Allowed toggling of agent capabilities via
command line flags.
Posted by Jie Yu <yu...@gmail.com>.
> On Nov. 7, 2017, 12:08 a.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Lines 8403 (patched)
> > <https://reviews.apache.org/r/63519/diff/4/?file=1881889#file1881889line8410>
> >
> > I'd avoid this static helper by just inline the code in the initializer:
> > ```
> > capabilities(_flags.agent_features.isNone()
> > : AGENT_CAPABILITIES()
> > ? _flags.agent_features->capabilities()),
> > ```
```
capabilities(_flags.agent_features.isNone()
: protobuf::slave::Capabilities(AGENT_CAPABILITIES())
? protobuf::slave::Capabilities(_flags.agent_features->capabilities())),
```
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/#review190248
-----------------------------------------------------------
On Nov. 6, 2017, 12:39 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63519/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2017, 12:39 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch introduces a new agent command line flags
> '--agent_features' which can be used to whitelist capabilities to
> enable. This flag is intended to enable introducing feature flags in
> the future so experimental features can be added while still reducing
> the risk of breaking existing functionality. Currently only the
> 'RESOURCE_PROVIDER' capability can be toggled.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c
> src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
> src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807
> src/slave/main.cpp 94431b036524ef4db16a594c80f45b64a45728f7
> src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
> src/slave/slave.cpp 79ee163b41ade93cae1054985379d61faf6a081a
>
>
> Diff: https://reviews.apache.org/r/63519/diff/4/
>
>
> Testing
> -------
>
> `make check`, tested as part of https://reviews.apache.org/r/63496/
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 63519: Allowed toggling of agent capabilities via
command line flags.
Posted by Benjamin Bannier <bb...@apache.org>.
> On Nov. 7, 2017, 1:08 a.m., Jie Yu wrote:
> > src/slave/main.cpp
> > Lines 377-394 (patched)
> > <https://reviews.apache.org/r/63519/diff/4/?file=1881887#file1881887line377>
> >
> > You can in fact do this (leverage the existing `protobuf::slave::Capabilities`)
> >
> > ```
> > protobuf::slave::Capabilities capabilities(
> > flags.agent_features->capabilities());
> >
> > if (!capabilities.multiRole ||
> > !capabilities.hierarchicalRole ||
> > !capabilities.reservationRefinement) {
> > return Error("...");
> > }
> >
> > return None();
> > ```
A `slave::Capabilities` can only be constructed from an iterable of `Capability`, but `flags.agent_features->capabilities` is an iterable of `Capability::Type`. Let's not pull another helper into this scope just to allow this conversion.
> On Nov. 7, 2017, 1:08 a.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Lines 8403 (patched)
> > <https://reviews.apache.org/r/63519/diff/4/?file=1881889#file1881889line8410>
> >
> > I'd avoid this static helper by just inline the code in the initializer:
> > ```
> > capabilities(_flags.agent_features.isNone()
> > : AGENT_CAPABILITIES()
> > ? _flags.agent_features->capabilities()),
> > ```
>
> Jie Yu wrote:
> ```
> capabilities(_flags.agent_features.isNone()
> : protobuf::slave::Capabilities(AGENT_CAPABILITIES())
> ? protobuf::slave::Capabilities(_flags.agent_features->capabilities())),
> ```
A `slave::Capabilities` can only be constructed from an iterable of `Capability`, but `flags.agent_features->capabilities` is an iterable of `Capability::Type` (chiefly to simplify the flags which need to be passed). The helper function constructs a `Capability`, and I'd rather keep it than introducing another global factory.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/#review190248
-----------------------------------------------------------
On Nov. 7, 2017, 1:25 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63519/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 1:25 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch introduces a new agent command line flags
> '--agent_features' which can be used to whitelist capabilities to
> enable. This flag is intended to enable introducing feature flags in
> the future so experimental features can be added while still reducing
> the risk of breaking existing functionality. Currently only the
> 'RESOURCE_PROVIDER' capability can be toggled.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c
> src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
> src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807
> src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
> src/slave/slave.cpp 79ee163b41ade93cae1054985379d61faf6a081a
>
>
> Diff: https://reviews.apache.org/r/63519/diff/5/
>
>
> Testing
> -------
>
> `make check`, tested as part of https://reviews.apache.org/r/63496/
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 63519: Allowed toggling of agent capabilities via
command line flags.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/#review190248
-----------------------------------------------------------
src/slave/main.cpp
Lines 377-394 (patched)
<https://reviews.apache.org/r/63519/#comment267549>
You can in fact do this (leverage the existing `protobuf::slave::Capabilities`)
```
protobuf::slave::Capabilities capabilities(
flags.agent_features->capabilities());
if (!capabilities.multiRole ||
!capabilities.hierarchicalRole ||
!capabilities.reservationRefinement) {
return Error("...");
}
return None();
```
src/slave/slave.cpp
Lines 8403 (patched)
<https://reviews.apache.org/r/63519/#comment267550>
I'd avoid this static helper by just inline the code in the initializer:
```
capabilities(_flags.agent_features.isNone()
: AGENT_CAPABILITIES()
? _flags.agent_features->capabilities()),
```
- Jie Yu
On Nov. 6, 2017, 12:39 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63519/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2017, 12:39 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch introduces a new agent command line flags
> '--agent_features' which can be used to whitelist capabilities to
> enable. This flag is intended to enable introducing feature flags in
> the future so experimental features can be added while still reducing
> the risk of breaking existing functionality. Currently only the
> 'RESOURCE_PROVIDER' capability can be toggled.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c
> src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
> src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807
> src/slave/main.cpp 94431b036524ef4db16a594c80f45b64a45728f7
> src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
> src/slave/slave.cpp 79ee163b41ade93cae1054985379d61faf6a081a
>
>
> Diff: https://reviews.apache.org/r/63519/diff/4/
>
>
> Testing
> -------
>
> `make check`, tested as part of https://reviews.apache.org/r/63496/
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 63519: Allowed toggling of agent capabilities via
command line flags.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/
-----------------------------------------------------------
(Updated Nov. 6, 2017, 1:39 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Addressed comment from Jie; rebased.
Repository: mesos
Description
-------
This patch introduces a new agent command line flags
'--agent_features' which can be used to whitelist capabilities to
enable. This flag is intended to enable introducing feature flags in
the future so experimental features can be added while still reducing
the risk of breaking existing functionality. Currently only the
'RESOURCE_PROVIDER' capability can be toggled.
Diffs (updated)
-----
docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c
src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807
src/slave/main.cpp 94431b036524ef4db16a594c80f45b64a45728f7
src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
src/slave/slave.cpp 79ee163b41ade93cae1054985379d61faf6a081a
Diff: https://reviews.apache.org/r/63519/diff/4/
Changes: https://reviews.apache.org/r/63519/diff/3-4/
Testing
-------
`make check`, tested as part of https://reviews.apache.org/r/63496/
Thanks,
Benjamin Bannier
Re: Review Request 63519: Allowed toggling of agent capabilities via
command line flags.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/
-----------------------------------------------------------
(Updated Nov. 3, 2017, 5:06 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Repository: mesos
Description
-------
This patch introduces a new agent command line flags
'--agent_features' which can be used to whitelist capabilities to
enable. This flag is intended to enable introducing feature flags in
the future so experimental features can be added while still reducing
the risk of breaking existing functionality. Currently only the
'RESOURCE_PROVIDER' capability can be toggled.
Diffs (updated)
-----
docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c
src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807
src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
src/slave/slave.cpp 79ee163b41ade93cae1054985379d61faf6a081a
Diff: https://reviews.apache.org/r/63519/diff/3/
Changes: https://reviews.apache.org/r/63519/diff/2-3/
Testing
-------
`make check`, tested as part of https://reviews.apache.org/r/63496/
Thanks,
Benjamin Bannier
Re: Review Request 63519: Allowed toggling of agent capabilities via
command line flags.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/
-----------------------------------------------------------
(Updated Nov. 3, 2017, 4:21 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Delegated parsing to protobuf.
Repository: mesos
Description
-------
This patch introduces a new agent command line flags
'--agent_features' which can be used to whitelist capabilities to
enable. This flag is intended to enable introducing feature flags in
the future so experimental features can be added while still reducing
the risk of breaking existing functionality. Currently only the
'RESOURCE_PROVIDER' capability can be toggled.
Diffs (updated)
-----
docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c
src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba
src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807
src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
src/slave/slave.cpp 79ee163b41ade93cae1054985379d61faf6a081a
Diff: https://reviews.apache.org/r/63519/diff/2/
Changes: https://reviews.apache.org/r/63519/diff/1-2/
Testing
-------
`make check`, tested as part of https://reviews.apache.org/r/63496/
Thanks,
Benjamin Bannier