You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/06/26 13:42:43 UTC

[GitHub] [nifi-minifi-cpp] hunyadi-dev opened a new pull request #825: MINIFICPP-1271 - Disable [build/include_subdir] linter check and remove related linter suppressions

hunyadi-dev opened a new pull request #825:
URL: https://github.com/apache/nifi-minifi-cpp/pull/825


   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #825: MINIFICPP-1271 - Disable [build/include_subdir] linter check and remove related linter suppressions

Posted by GitBox <gi...@apache.org>.
hunyadi-dev commented on a change in pull request #825:
URL: https://github.com/apache/nifi-minifi-cpp/pull/825#discussion_r446237511



##########
File path: libminifi/include/agent/CPPLINT.cfg
##########
@@ -1,3 +1,3 @@
 set noparent

Review comment:
       It was indeed a duplicate, modified as requested.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #825: MINIFICPP-1271 - Disable [build/include_subdir] linter check and remove related linter suppressions

Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #825:
URL: https://github.com/apache/nifi-minifi-cpp/pull/825


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #825: MINIFICPP-1271 - Disable [build/include_subdir] linter check and remove related linter suppressions

Posted by GitBox <gi...@apache.org>.
arpadboda commented on a change in pull request #825:
URL: https://github.com/apache/nifi-minifi-cpp/pull/825#discussion_r446214980



##########
File path: libminifi/include/agent/CPPLINT.cfg
##########
@@ -1,3 +1,3 @@
 set noparent

Review comment:
       Not sure why we have noparent setting here. The content just seems to duplicate the root cppling.cfg, so I think both line 1 and 2 can be removed from this file. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org