You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by jm...@apache.org on 2013/08/27 06:36:11 UTC

git commit: [flex-sdk] [refs/heads/develop] - FLEX-33682 Significantly improved ADG performance in regards resizing, scrolling (especially horizontal) and redrawing

Updated Branches:
  refs/heads/develop a7c6f9750 -> ef87141ac


FLEX-33682 Significantly improved ADG performance in regards resizing, scrolling (especially horizontal) and redrawing


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/ef87141a
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/ef87141a
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/ef87141a

Branch: refs/heads/develop
Commit: ef87141acb3151138bd3b471d178449fda2caba2
Parents: a7c6f97
Author: Justin Mclean <jm...@apache.org>
Authored: Tue Aug 27 14:25:18 2013 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Tue Aug 27 14:25:18 2013 +1000

----------------------------------------------------------------------
 .../src/mx/controls/AdvancedDataGridBaseEx.as   | 22 +++++++++++++++++++-
 .../AdvancedDataGridHeaderRenderer.as           |  2 +-
 .../AdvancedDataGridSortItemRenderer.as         |  2 +-
 .../FTEAdvancedDataGridItemRenderer.as          |  2 +-
 4 files changed, 24 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/ef87141a/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as b/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as
index 9c3a3f4..942f2bf 100644
--- a/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as
+++ b/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as
@@ -1063,7 +1063,7 @@ public class AdvancedDataGridBaseEx extends AdvancedDataGridBase implements IIME
      *  Some may be offscreen depending on horizontalScrollPolicy
      *  and the width of the AdvancedDataGrid.
      */
-    override  public function get columnCount():int
+    override public function get columnCount():int
     {
         if (_columns)
             return _columns.length;
@@ -1377,6 +1377,26 @@ public class AdvancedDataGridBaseEx extends AdvancedDataGridBase implements IIME
         invalidateDisplayList();
         dispatchEvent(new Event("columnsChanged"));
     }
+	
+	/**
+	 *  An array of AdvancedDataGridColumn objects, one for each column that
+	 *  can be displayed. 
+	 * 
+	 *  <p>Used internally instead of using <code>columns<code> when higher
+	 *  performance is required.</p>
+	 *
+	 *  <p>Use externally with caution and don't modify the array that comes
+	 *  back or you may get unexpected issues.</p>
+	 *   
+	 *  @langversion 3.0
+	 *  @playerversion Flash 9
+	 *  @playerversion AIR 1.1
+	 *  @productversion Flex 4.11
+	 */
+	public function get rawColumns():Array {
+		return _columns;
+	}
+	
     
     //----------------------------------
     //  draggableColumns

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/ef87141a/frameworks/projects/advancedgrids/src/mx/controls/advancedDataGridClasses/AdvancedDataGridHeaderRenderer.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/advancedgrids/src/mx/controls/advancedDataGridClasses/AdvancedDataGridHeaderRenderer.as b/frameworks/projects/advancedgrids/src/mx/controls/advancedDataGridClasses/AdvancedDataGridHeaderRenderer.as
index 586626e..741fc05 100644
--- a/frameworks/projects/advancedgrids/src/mx/controls/advancedDataGridClasses/AdvancedDataGridHeaderRenderer.as
+++ b/frameworks/projects/advancedgrids/src/mx/controls/advancedDataGridClasses/AdvancedDataGridHeaderRenderer.as
@@ -819,7 +819,7 @@ public class AdvancedDataGridHeaderRenderer
      */
     protected function getFieldSortInfo():SortInfo
     {
-       	return grid.getFieldSortInfo(grid.columns[listData.columnIndex]);
+       	return grid.getFieldSortInfo(grid.rawColumns[listData.columnIndex]);
     }
 
     //--------------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/ef87141a/frameworks/projects/advancedgrids/src/mx/controls/advancedDataGridClasses/AdvancedDataGridSortItemRenderer.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/advancedgrids/src/mx/controls/advancedDataGridClasses/AdvancedDataGridSortItemRenderer.as b/frameworks/projects/advancedgrids/src/mx/controls/advancedDataGridClasses/AdvancedDataGridSortItemRenderer.as
index 4a77ee1..45e82ba 100644
--- a/frameworks/projects/advancedgrids/src/mx/controls/advancedDataGridClasses/AdvancedDataGridSortItemRenderer.as
+++ b/frameworks/projects/advancedgrids/src/mx/controls/advancedDataGridClasses/AdvancedDataGridSortItemRenderer.as
@@ -484,7 +484,7 @@ public class AdvancedDataGridSortItemRenderer extends UIComponent
             var listData:AdvancedDataGridListData = (parent as IDropInListItemRenderer).listData
                                                     as AdvancedDataGridListData;
             if (listData && listData.columnIndex != -1)
-                return grid.getFieldSortInfo(grid.columns[listData.columnIndex]);
+                return grid.getFieldSortInfo(grid.rawColumns[listData.columnIndex]);
         }
 
         return null;

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/ef87141a/frameworks/projects/spark_dmv/src/mx/controls/advancedDataGridClasses/FTEAdvancedDataGridItemRenderer.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/spark_dmv/src/mx/controls/advancedDataGridClasses/FTEAdvancedDataGridItemRenderer.as b/frameworks/projects/spark_dmv/src/mx/controls/advancedDataGridClasses/FTEAdvancedDataGridItemRenderer.as
index 6aab54c..ea2c84b 100644
--- a/frameworks/projects/spark_dmv/src/mx/controls/advancedDataGridClasses/FTEAdvancedDataGridItemRenderer.as
+++ b/frameworks/projects/spark_dmv/src/mx/controls/advancedDataGridClasses/FTEAdvancedDataGridItemRenderer.as
@@ -456,7 +456,7 @@ public class FTEAdvancedDataGridItemRenderer extends UIFTETextField
             var dg:AdvancedDataGrid = AdvancedDataGrid(_listData.owner);
 
             var column:AdvancedDataGridColumn =
-                dg.columns[_listData.columnIndex];
+                dg.rawColumns[_listData.columnIndex];
 
             text = _listData.label;